proxmox-mirrors/proxmox-widget-toolkit
1
0
Fork 1
mirror of https://git.proxmox.com/git/proxmox-widget-toolkit synced 2025-05-09 20:39:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix #4612: mobile: avoid crash due to missing getProxy method

Browse Source 
A previous commit (51083ee) added an override of the internal ExtJS
method `Ext.data.Store.onProxyLoad` in order to fix a race condition.
This override calls `Operation.getProxy`. However, this method is not
available on Sencha Touch. As a consequence, the mobile UI was
broken.

This commit modifies the override such that it has no effect in the
mobile UI.

Fixes: 51083ee54a
Suggested-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
Friedrich Weber 2023-03-24 10:02:30 +01:00 committed by Thomas Lamprecht
parent 311fb72a27
commit 4fedb4e28d
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Utils.js
View File

@ -1483,10 +1483,11 @@ Ext.override(Ext.data.Store, {
// If the store's proxy is changed while it is waiting for an AJAX // If the store's proxy is changed while it is waiting for an AJAX
// response, `onProxyLoad` will still be called for the outdated response. // response, `onProxyLoad` will still be called for the outdated response.
// To avoid displaying inconsistent information, only process responses // To avoid displaying inconsistent information, only process responses
// belonging to the current proxy. // belonging to the current proxy. However, do not apply this workaround
// to the mobile UI, as Sencha Touch has an incompatible internal API.
onProxyLoad: function(operation) { onProxyLoad: function(operation) {
let me = this; let me = this;
if (operation.getProxy() === me.getProxy()) { if (Proxmox.Utils.toolkit === 'touch' || operation.getProxy() === me.getProxy()) {
me.callParent(arguments); me.callParent(arguments);
} else { } else {
console.log(`ignored outdated response: ${operation.getRequest().getUrl()}`); console.log(`ignored outdated response: ${operation.getRequest().getUrl()}`);