From 461298d80ad0d52740222c1af82e4427aa8e0bd5 Mon Sep 17 00:00:00 2001 From: Christian Ebner Date: Tue, 19 Nov 2024 14:02:53 +0100 Subject: [PATCH] utils: never translate systemd unit states Translating unit states might be counter productive in case of debugging, opt for not translating them and drop usage of the translation helper. This was spotted by several devs on doing translations in languages they know, so it really seems not right to add. Signed-off-by: Christian Ebner [ TL: add last sentence to add some weight to not doing that ] Signed-off-by: Thomas Lamprecht --- src/Utils.js | 12 ------------ src/node/ServiceView.js | 10 ++-------- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a/src/Utils.js b/src/Utils.js index 978b558..1ee4039 100644 --- a/src/Utils.js +++ b/src/Utils.js @@ -306,18 +306,6 @@ utilities: { return Ext.htmlEncode(username); }, - systemdStates: { - 'enabled': gettext('enabled'), - 'disabled': gettext('disabled'), - 'running': gettext('running'), - 'dead': gettext('dead'), - 'not-found': gettext('not installed'), - 'static': gettext('static'), - 'reload': gettext('reload'), - 'start': gettext('starting'), - 'stop': gettext('stopping'), - }, - getStoredAuth: function() { let storedAuth = JSON.parse(window.localStorage.getItem('ProxmoxUser')); return storedAuth || {}; diff --git a/src/node/ServiceView.js b/src/node/ServiceView.js index 94f523c..210dd83 100644 --- a/src/node/ServiceView.js +++ b/src/node/ServiceView.js @@ -201,10 +201,7 @@ Ext.define('Proxmox.node.ServiceView', { width: 100, sortable: true, dataIndex: 'state', - renderer: (value, meta, rec) => { - const state = rec.get('state'); - return Proxmox.Utils.systemdStates[state] ?? state; - }, + renderer: (value, meta, rec) => rec.get('state'), }, { header: gettext('Active'), @@ -219,10 +216,7 @@ Ext.define('Proxmox.node.ServiceView', { sortable: true, hidden: !Ext.Array.contains(['PVEAuthCookie', 'PBSAuthCookie'], Proxmox?.Setup?.auth_cookie_name), dataIndex: 'unit-state', - renderer: (value, meta, rec) => { - const unitState = rec.get('unit-state'); - return Proxmox.Utils.systemdStates[unitState] ?? unitState; - }, + renderer: (value, meta, rec) => rec.get('unit-state'), }, { header: gettext('Description'),