From 41c844b5110a2289d40c4a750bd06cc6d078fe0e Mon Sep 17 00:00:00 2001 From: Maximiliano Sandoval Date: Tue, 28 Jan 2025 10:31:59 +0100 Subject: [PATCH] fix #6088: notification: matcher: use more descriptive strings Add separate text for inverted and non-inverted cases, this should reduce some confusion about how inversion works and allow for better translations. Signed-off-by: Maximiliano Sandoval Tested-by: Lukas Wagner Reviewed-by: Lukas Wagner [TL: expand commit message.] Signed-off-by: Thomas Lamprecht --- src/window/NotificationMatcherEdit.js | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/window/NotificationMatcherEdit.js b/src/window/NotificationMatcherEdit.js index 9ab443f..83c09ea 100644 --- a/src/window/NotificationMatcherEdit.js +++ b/src/window/NotificationMatcherEdit.js @@ -491,12 +491,17 @@ Ext.define('Proxmox.panel.NotificationMatchRuleTree', { } break; case 'mode': if (data.value === 'all') { - text = gettext("All"); + if (data.invert) { + text = gettext('At least one rule does not match'); + } else { + text = gettext('All rules match'); + } } else if (data.value === 'any') { - text = gettext("Any"); - } - if (data.invert) { - text = `!${text}`; + if (data.invert) { + text = gettext('No rule matches'); + } else { + text = gettext('Any rule matches'); + } } iconCls = 'fa fa-filter';