From 358b98bf4f049d3fb9c056ec333d4684e00e600d Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Sat, 16 Nov 2024 16:35:49 +0100 Subject: [PATCH] network edit: rename bridge_set_vids to enableBridgeVlanIds we use camelCase in the JavaScript code and besides casing the old name wasn't really telling and suggested that it was there to set a specific VID not to enable setting them. Signed-off-by: Thomas Lamprecht --- src/node/NetworkEdit.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js index 1a61c11..b9606af 100644 --- a/src/node/NetworkEdit.js +++ b/src/node/NetworkEdit.js @@ -3,7 +3,7 @@ Ext.define('Proxmox.node.NetworkEdit', { alias: ['widget.proxmoxNodeNetworkEdit'], // Enable to show the VLAN ID field - bridge_set_vids: false, + enableBridgeVlanIds: false, initComponent: function() { let me = this; @@ -60,7 +60,7 @@ Ext.define('Proxmox.node.NetworkEdit', { } if (me.iftype === 'bridge') { - let vids = Ext.create('Ext.form.field.Text', { + let vlanIdsField = !me.enableBridgeVlanIds ? undefined : Ext.create('Ext.form.field.Text', { fieldLabel: gettext('VLAN IDs'), name: 'bridge_vids', emptyText: '2-4094', @@ -102,8 +102,8 @@ Ext.define('Proxmox.node.NetworkEdit', { deleteEmpty: !me.isCreate, listeners: { change: function(f, newVal) { - if (me.bridge_set_vids) { - vids.setDisabled(!newVal); + if (vlanIdsField) { + vlanIdsField.setDisabled(!newVal); } }, }, @@ -117,8 +117,8 @@ Ext.define('Proxmox.node.NetworkEdit', { 'data-qtip': gettext('Space-separated list of interfaces, for example: enp0s0 enp1s0'), }, }); - if (me.bridge_set_vids) { - advancedColumn2.push(vids); + if (vlanIdsField) { + advancedColumn2.push(vlanIdsField); } } else if (me.iftype === 'OVSBridge') { column2.push({