From 3375d11ea4ed05008a1fa4428bfa55184b347005 Mon Sep 17 00:00:00 2001
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Date: Tue, 19 Nov 2024 12:37:25 +0100
Subject: [PATCH] auth view/edit: make default-view checkbox opt-in

To avoid suggesting that a project has a feature that is not
implemented in the backend.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
 src/panel/AuthView.js        | 8 +++++++-
 src/window/AuthEditBase.js   | 5 +++++
 src/window/AuthEditLDAP.js   | 6 ++++--
 src/window/AuthEditOpenId.js | 4 ++++
 src/window/AuthEditSimple.js | 6 ++++++
 5 files changed, 26 insertions(+), 3 deletions(-)

diff --git a/src/panel/AuthView.js b/src/panel/AuthView.js
index c297544..f607532 100644
--- a/src/panel/AuthView.js
+++ b/src/panel/AuthView.js
@@ -1,7 +1,9 @@
 Ext.define('Proxmox.panel.AuthView', {
     extend: 'Ext.grid.GridPanel',
-
     alias: 'widget.pmxAuthView',
+    mixins: ['Proxmox.Mixin.CBind'],
+
+    showDefaultRealm: false,
 
     stateful: true,
     stateId: 'grid-authrealms',
@@ -32,6 +34,9 @@ Ext.define('Proxmox.panel.AuthView', {
 	    dataIndex: 'default',
 	    renderer: isDefault => isDefault ? Proxmox.Utils.renderEnabledIcon(true) : '',
 	    align: 'center',
+	    cbind: {
+		hidden: '{!showDefaultRealm}',
+	    },
 	},
 	{
 	    header: gettext('Comment'),
@@ -60,6 +65,7 @@ Ext.define('Proxmox.panel.AuthView', {
 	    onlineHelp,
 	    authType,
 	    realm,
+	    showDefaultRealm: me.showDefaultRealm,
 	    listeners: {
 		destroy: () => me.reload(),
 	    },
diff --git a/src/window/AuthEditBase.js b/src/window/AuthEditBase.js
index be547f9..73c1fee 100644
--- a/src/window/AuthEditBase.js
+++ b/src/window/AuthEditBase.js
@@ -1,5 +1,8 @@
 Ext.define('Proxmox.window.AuthEditBase', {
     extend: 'Proxmox.window.Edit',
+    mixins: ['Proxmox.Mixin.CBind'],
+
+    showDefaultRealm: false,
 
     isAdd: true,
 
@@ -53,6 +56,7 @@ Ext.define('Proxmox.window.AuthEditBase', {
 			isCreate: me.isCreate,
 			useTypeInUrl: me.useTypeInUrl,
 			type: me.authType,
+			showDefaultRealm: me.showDefaultRealm,
 		    },
 		    {
 			title: gettext('Sync Options'),
@@ -70,6 +74,7 @@ Ext.define('Proxmox.window.AuthEditBase', {
 		isCreate: me.isCreate,
 		useTypeInUrl: me.useTypeInUrl,
 		type: me.authType,
+		showDefaultRealm: me.showDefaultRealm,
 	    }];
 	}
 
diff --git a/src/window/AuthEditLDAP.js b/src/window/AuthEditLDAP.js
index 4cd1020..a2c96b0 100644
--- a/src/window/AuthEditLDAP.js
+++ b/src/window/AuthEditLDAP.js
@@ -1,7 +1,5 @@
-
 Ext.define('Proxmox.panel.LDAPInputPanelViewModel', {
     extend: 'Ext.app.ViewModel',
-
     alias: 'viewmodel.pmxAuthLDAPPanel',
 
     data: {
@@ -23,6 +21,8 @@ Ext.define('Proxmox.panel.LDAPInputPanel', {
     xtype: 'pmxAuthLDAPPanel',
     mixins: ['Proxmox.Mixin.CBind'],
 
+    showDefaultRealm: false,
+
     viewModel: {
 	type: 'pmxAuthLDAPPanel',
     },
@@ -89,6 +89,8 @@ Ext.define('Proxmox.panel.LDAPInputPanel', {
 	    value: 0,
 	    cbind: {
 		deleteEmpty: '{!isCreate}',
+		hidden: '{!showDefaultRealm}',
+		disabled: '{!showDefaultRealm}',
 	    },
 	    autoEl: {
 		tag: 'div',
diff --git a/src/window/AuthEditOpenId.js b/src/window/AuthEditOpenId.js
index a9ccb92..ed0a6dc 100644
--- a/src/window/AuthEditOpenId.js
+++ b/src/window/AuthEditOpenId.js
@@ -3,6 +3,8 @@ Ext.define('Proxmox.panel.OpenIDInputPanel', {
     xtype: 'pmxAuthOpenIDPanel',
     mixins: ['Proxmox.Mixin.CBind'],
 
+    showDefaultRealm: false,
+
     type: 'openid',
 
     onGetValues: function(values) {
@@ -42,6 +44,8 @@ Ext.define('Proxmox.panel.OpenIDInputPanel', {
 	    value: 0,
 	    cbind: {
 		deleteEmpty: '{!isCreate}',
+		hidden: '{!showDefaultRealm}',
+		disabled: '{!showDefaultRealm}',
 	    },
 	    autoEl: {
 		tag: 'div',
diff --git a/src/window/AuthEditSimple.js b/src/window/AuthEditSimple.js
index f6521bd..dd09919 100644
--- a/src/window/AuthEditSimple.js
+++ b/src/window/AuthEditSimple.js
@@ -3,6 +3,8 @@ Ext.define('Proxmox.panel.SimpleRealmInputPanel', {
     xtype: 'pmxAuthSimplePanel',
     mixins: ['Proxmox.Mixin.CBind'],
 
+    showDefaultRealm: false,
+
     column1: [
 	{
 	    xtype: 'pmxDisplayEditField',
@@ -22,6 +24,10 @@ Ext.define('Proxmox.panel.SimpleRealmInputPanel', {
 		tag: 'div',
 		'data-qtip': gettext('Set realm as default for login'),
 	    },
+	    cbind: {
+		hidden: '{!showDefaultRealm}',
+		disabled: '{!showDefaultRealm}',
+	    },
 	},
     ],