StdRemoveButton: code cleanup

most done by eslint --fix, a bit tinkered manually though

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2020-04-18 19:27:24 +02:00
parent 8886099fa5
commit 1f315ec805

View File

@ -10,7 +10,9 @@ Ext.define('Proxmox.button.Button', {
selModel: undefined, selModel: undefined,
// if 'false' handler will not be called (button disabled) // if 'false' handler will not be called (button disabled)
enableFn: function(record) { }, enableFn: function(record) {
// return undefined by default
},
// function(record) or text // function(record) or text
confirmMsg: false, confirmMsg: false,
@ -19,12 +21,9 @@ Ext.define('Proxmox.button.Button', {
dangerous: false, dangerous: false,
initComponent: function() { initComponent: function() {
/*jslint confusion: true */
var me = this; var me = this;
if (me.handler) { if (me.handler) {
// Note: me.realHandler may be a string (see named scopes) // Note: me.realHandler may be a string (see named scopes)
var realHandler = me.handler; var realHandler = me.handler;
@ -32,7 +31,7 @@ Ext.define('Proxmox.button.Button', {
var rec, msg; var rec, msg;
if (me.selModel) { if (me.selModel) {
rec = me.selModel.getSelection()[0]; rec = me.selModel.getSelection()[0];
if (!rec || (me.enableFn(rec) === false)) { if (!rec || me.enableFn(rec) === false) {
return; return;
} }
} }
@ -54,7 +53,7 @@ Ext.define('Proxmox.button.Button', {
return; return;
} }
Ext.callback(realHandler, me.scope, [button, event, rec], 0, me); Ext.callback(realHandler, me.scope, [button, event, rec], 0, me);
} },
}); });
} else { } else {
Ext.callback(realHandler, me.scope, [button, event, rec], 0, me); Ext.callback(realHandler, me.scope, [button, event, rec], 0, me);
@ -82,17 +81,16 @@ Ext.define('Proxmox.button.Button', {
} }
if (me.selModel) { if (me.selModel) {
me.mon(me.selModel, "selectionchange", function() { me.mon(me.selModel, "selectionchange", function() {
var rec = me.selModel.getSelection()[0]; var rec = me.selModel.getSelection()[0];
if (!rec || (me.enableFn(rec) === false)) { if (!rec || me.enableFn(rec) === false) {
me.setDisabled(true); me.setDisabled(true);
} else { } else {
me.setDisabled(false); me.setDisabled(false);
} }
}); });
} }
} },
}); });
@ -108,7 +106,7 @@ Ext.define('Proxmox.button.StdRemoveButton', {
delay: undefined, delay: undefined,
config: { config: {
baseurl: undefined baseurl: undefined,
}, },
getUrl: function(rec) { getUrl: function(rec) {
@ -122,17 +120,17 @@ Ext.define('Proxmox.button.StdRemoveButton', {
}, },
// also works with names scopes // also works with names scopes
callback: function(options, success, response) {}, callback: function(options, success, response) {
// do nothing by default
},
getRecordName: function(rec) { return rec.getId() }, getRecordName: (rec) => rec.getId(),
confirmMsg: function (rec) { confirmMsg: function(rec) {
var me = this; var me = this;
var name = me.getRecordName(rec); var name = me.getRecordName(rec);
return Ext.String.format( return Ext.String.format(gettext('Are you sure you want to remove entry {0}'), `'${name}'`);
gettext('Are you sure you want to remove entry {0}'),
"'" + name + "'");
}, },
handler: function(btn, event, rec) { handler: function(btn, event, rec) {
@ -140,7 +138,7 @@ Ext.define('Proxmox.button.StdRemoveButton', {
var url = me.getUrl(rec); var url = me.getUrl(rec);
if (typeof me.delay !== 'undefined' && me .delay >= 0) { if (typeof me.delay !== 'undefined' && me.delay >= 0) {
url += "?delay=" + me.delay; url += "?delay=" + me.delay;
} }
@ -151,17 +149,17 @@ Ext.define('Proxmox.button.StdRemoveButton', {
callback: function(options, success, response) { callback: function(options, success, response) {
Ext.callback(me.callback, me.scope, [options, success, response], 0, me); Ext.callback(me.callback, me.scope, [options, success, response], 0, me);
}, },
failure: function (response, opts) { failure: function(response, opts) {
Ext.Msg.alert(gettext('Error'), response.htmlStatus); Ext.Msg.alert(gettext('Error'), response.htmlStatus);
} },
}); });
}, },
initComponent: function() { initComponent: function() {
let me = this; let me = this;
// enable by default if no seleModel is there and disabled not set // enable by default if no seleModel is there and disabled not set
if (me.initialConfig.disabled === undefined if (me.initialConfig.disabled === undefined &&
&& (me.selModel === null || me.selModel === false)) { (me.selModel === null || me.selModel === false)) {
me.disabled = false; me.disabled = false;
} }