From 15f0d995348574911ae25c284c6d71ec71402a66 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Fri, 17 Nov 2023 15:00:30 +0100 Subject: [PATCH] form: displaye-edit: add one of the two missing returns the other one _should_ not be problematic, as field-container itself isn't picked up as a "real" field itself, but we might bind to that somewhere, where enabling could break this. The editable one seems to not be used yet, according to Dominik, so fix that now already. Signed-off-by: Thomas Lamprecht --- src/form/DisplayEdit.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/form/DisplayEdit.js b/src/form/DisplayEdit.js index 97b443f..fe1b83b 100644 --- a/src/form/DisplayEdit.js +++ b/src/form/DisplayEdit.js @@ -24,7 +24,7 @@ Ext.define('Proxmox.form.field.DisplayEdit', { getEditable: function() { let me = this; let vm = me.getViewModel(); - vm.get('editable'); + return vm.get('editable'); }, setValue: function(value) { @@ -37,6 +37,7 @@ Ext.define('Proxmox.form.field.DisplayEdit', { getValue: function() { let me = this; let vm = me.getViewModel(); + // FIXME: add return, but check all use-sites for regressions then vm.get('value'); },