node status view: code cleanup

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2021-04-22 15:32:27 +02:00
parent b87d473347
commit 0d58bef75c

View File

@ -9,20 +9,20 @@ Ext.define('Proxmox.panel.StatusView', {
title: gettext('Status'), title: gettext('Status'),
getRecordValue: function(key, store) { getRecordValue: function(key, store) {
let me = this;
if (!key) { if (!key) {
throw "no key given"; throw "no key given";
} }
var me = this;
if (store === undefined) { if (store === undefined) {
store = me.getStore(); store = me.getStore();
} }
var rec = store.getById(key); let rec = store.getById(key);
if (rec) { if (rec) {
return rec.data.value; return rec.data.value;
} }
return ''; return '';
}, },
@ -55,8 +55,8 @@ Ext.define('Proxmox.panel.StatusView', {
}, },
updateField: function(field) { updateField: function(field) {
var me = this; let me = this;
var renderer = me.fieldRenderer; let renderer = me.fieldRenderer;
if (Ext.isFunction(field.renderer)) { if (Ext.isFunction(field.renderer)) {
renderer = field.renderer; renderer = field.renderer;
} }
@ -65,12 +65,10 @@ Ext.define('Proxmox.panel.StatusView', {
} else if (field.textField !== undefined) { } else if (field.textField !== undefined) {
field.updateValue(renderer.call(field, me.getRecordValue(field.textField))); field.updateValue(renderer.call(field, me.getRecordValue(field.textField)));
} else if (field.valueField !== undefined) { } else if (field.valueField !== undefined) {
var used = me.getRecordValue(field.valueField); let used = me.getRecordValue(field.valueField);
/* string and int */ let max = field.maxField !== undefined ? me.getRecordValue(field.maxField) : 1;
var max = field.maxField !== undefined ? me.getRecordValue(field.maxField) : 1;
var calculate = me.fieldCalculator;
let calculate = me.fieldCalculator;
if (Ext.isFunction(field.calculate)) { if (Ext.isFunction(field.calculate)) {
calculate = field.calculate; calculate = field.calculate;
} }
@ -79,7 +77,8 @@ Ext.define('Proxmox.panel.StatusView', {
}, },
getStore: function() { getStore: function() {
var me = this; let me = this;
if (!me.rstore) { if (!me.rstore) {
throw "there is no rstore"; throw "there is no rstore";
} }
@ -88,29 +87,28 @@ Ext.define('Proxmox.panel.StatusView', {
}, },
updateTitle: function() { updateTitle: function() {
var me = this; let me = this;
me.setTitle(me.getRecordValue('name')); me.setTitle(me.getRecordValue('name'));
}, },
updateValues: function(store, records, success) { updateValues: function(store, records, success) {
let me = this;
if (!success) { if (!success) {
return; // do not update if store load was not successful return; // do not update if store load was not successful
} }
var me = this;
var itemsToUpdate = me.query('pmxInfoWidget');
itemsToUpdate.forEach(me.updateField, me); me.query('pmxInfoWidget').forEach(me.updateField, me);
me.updateTitle(store); me.updateTitle(store);
}, },
initComponent: function() { initComponent: function() {
var me = this; let me = this;
if (!me.rstore) { if (!me.rstore) {
throw "no rstore given"; throw "no rstore given";
} }
if (!me.title) { if (!me.title) {
throw "no title given"; throw "no title given";
} }