From d08df4668398ea9a7ee16f20dbe122f8cb2fa0f1 Mon Sep 17 00:00:00 2001 From: Gabriel Goller Date: Tue, 18 Feb 2025 17:16:41 +0100 Subject: [PATCH] log: use new logging builder, print to stderr and journald Use the new builder. Print the logs to stderr and journald always. Remove the log dependency. Suggested-by: Lukas Wagner Signed-off-by: Gabriel Goller --- common/src/logger.rs | 7 ++++++- pmg-rs/Cargo.toml | 1 - pmg-rs/src/lib.rs | 2 +- pve-rs/Cargo.toml | 1 - 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/common/src/logger.rs b/common/src/logger.rs index 1c8940b..946ecab 100644 --- a/common/src/logger.rs +++ b/common/src/logger.rs @@ -5,7 +5,12 @@ pub fn init(env_var_name: &str, default_log_level: &str) { if let Err(e) = default_log_level .parse() .map_err(Error::from) - .and_then(|default_log_level| proxmox_log::init_logger(env_var_name, default_log_level)) + .and_then(|default_log_level| { + proxmox_log::Logger::from_env(env_var_name, default_log_level) + .stderr_pve() + .journald() + .init() + }) { eprintln!("could not set up env_logger: {e:?}"); } diff --git a/pmg-rs/Cargo.toml b/pmg-rs/Cargo.toml index a6f4bb1..197ea33 100644 --- a/pmg-rs/Cargo.toml +++ b/pmg-rs/Cargo.toml @@ -18,7 +18,6 @@ anyhow = "1.0" hex = "0.4" http = "0.2.7" libc = "0.2" -log = "0.4.17" nix = "0.26" openssl = "0.10.40" serde = "1.0" diff --git a/pmg-rs/src/lib.rs b/pmg-rs/src/lib.rs index 3db6966..0ebe285 100644 --- a/pmg-rs/src/lib.rs +++ b/pmg-rs/src/lib.rs @@ -29,7 +29,7 @@ mod export { } pub fn send_updates_available(_updates: &[&APTUpdateInfo]) -> Result<(), Error> { - log::warn!("update notifications are not implemented for PMG yet"); + tracing::warn!("update notifications are not implemented for PMG yet"); Ok(()) } diff --git a/pve-rs/Cargo.toml b/pve-rs/Cargo.toml index 81a8396..f2e495d 100644 --- a/pve-rs/Cargo.toml +++ b/pve-rs/Cargo.toml @@ -20,7 +20,6 @@ base64 = "0.13" hex = "0.4" http = "0.2.7" libc = "0.2" -log = "0.4.17" nix = "0.26" openssl = "0.10.40" serde = "1.0"