From dc99315cf99ead449028663e774699e46469f803 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Sat, 3 Jul 2021 23:12:03 +0200 Subject: [PATCH] ui: app: fix openID helper usage and rework style one really does not need a if and an extra intermediate variable for assigning a simple bool... Signed-off-by: Thomas Lamprecht --- www/Application.js | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/www/Application.js b/www/Application.js index 20ae26bd..55a5ec3c 100644 --- a/www/Application.js +++ b/www/Application.js @@ -49,16 +49,11 @@ Ext.define('PBS.Application', { var provider = new Ext.state.LocalStorageProvider({ prefix: 'ext-pbs-' }); Ext.state.Manager.setProvider(provider); - let openid_login = false; - let param = PBS.Utils.openid_login_param(); - if (param !== undefined) { - openid_login = true; - } + let isOpenIDLogin = Proxmox.Utils.getOpenIDRedirectionAuthorization() !== undefined; + let alreadyLoggedIn = Proxmox.Utils.authOK(); - // show login window if not loggedin - var loggedin = Proxmox.Utils.authOK(); - if (openid_login || !loggedin) { - me.changeView('loginview', true); + if (isOpenIDLogin || !alreadyLoggedIn) { + me.changeView('loginview', true); // show login window if not loggedin } else { me.changeView('mainview', true); }