From d43265b7f1c3cd457920c4ce0bf1e957d1fca3c3 Mon Sep 17 00:00:00 2001 From: Oguz Bektas Date: Tue, 19 Jan 2021 14:33:23 +0100 Subject: [PATCH] ui: add missing uri encoding in user edit and view userid parameter needs to be properly encoded when shown on the browser Signed-off-by: Oguz Bektas Reviewed-by: Dominik Csapak --- www/config/UserView.js | 2 ++ www/window/UserEdit.js | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/www/config/UserView.js b/www/config/UserView.js index 4645737a..ae313776 100644 --- a/www/config/UserView.js +++ b/www/config/UserView.js @@ -139,6 +139,8 @@ Ext.define('PBS.config.UserView', { xtype: 'proxmoxStdRemoveButton', baseurl: '/access/users/', enableFn: (rec) => rec.data.userid !== 'root@pam', + getUrl: (rec) => + `/access/users/${encodeURIComponent(rec.getId())}`, callback: 'reload', }, '-', diff --git a/www/window/UserEdit.js b/www/window/UserEdit.js index aaae835f..06ec5377 100644 --- a/www/window/UserEdit.js +++ b/www/window/UserEdit.js @@ -20,7 +20,7 @@ Ext.define('PBS.window.UserEdit', { var baseurl = '/api2/extjs/access/users'; me.isCreate = !userid; - me.url = userid ? baseurl + '/' + userid : baseurl; + me.url = userid ? baseurl + '/' + encodeURIComponent(userid) : baseurl; me.method = userid ? 'PUT' : 'POST'; me.autoLoad = !!userid;