proxmox-mirrors/proxmox-backup
1
0
Fork 1
mirror of https://git.proxmox.com/git/proxmox-backup synced 2025-05-29 22:13:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

tape: avoid panic potential in MAM attribute decoder

Browse Source 
We already saw that quite some tape libraries/loaders/... ain't
always _that_ standard conform, and even if it'd be guaranteed, it
just makes no sense to create a potential for panicking the whole
daemon due to some sub-features hiccup, rather go for actual error
handling...

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2023-05-17 14:57:15 +02:00
parent a4ff2cdc54
commit a18a63c827
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pbs-tape/src/sg_tape/mam.rs
View File

@ -257,7 +257,7 @@ fn decode_mam_attributes(data: &[u8]) -> Result<Vec<MamAttribute>, Error> {
format!("{}", u64::from_be_bytes(data[0..8].try_into()?)) format!("{}", u64::from_be_bytes(data[0..8].try_into()?))
} }
} else { } else {
unreachable!(); bail!("unexpected MAM attribute length {}", info.1);
} }
} }
MamFormat::BINARY => hex::encode(&data), MamFormat::BINARY => hex::encode(&data),