From 7eebe1483e6f37de6179dc4b9f1ece507b47be71 Mon Sep 17 00:00:00 2001 From: Dominik Csapak Date: Tue, 29 Sep 2020 12:22:02 +0200 Subject: [PATCH] server/worker_task: fix panic on slice range when index is empty since len() and MAX_INDEX_TASKS are both usize, they underflow instead of getting negative values instead check the sizes and set them accordingly Signed-off-by: Dominik Csapak --- src/server/worker_task.rs | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/src/server/worker_task.rs b/src/server/worker_task.rs index 2b517a79..be689c7f 100644 --- a/src/server/worker_task.rs +++ b/src/server/worker_task.rs @@ -418,9 +418,20 @@ fn update_active_workers(new_upid: Option<&UPID>) -> Result<(), Error> { } }); - let start = (finish_list.len()-MAX_INDEX_TASKS).max(0); + + let start = if finish_list.len() > MAX_INDEX_TASKS { + finish_list.len() - MAX_INDEX_TASKS + } else { + 0 + }; + let end = (start+MAX_INDEX_TASKS).min(finish_list.len()); - let index_raw = render_task_list(&finish_list[start..end]); + + let index_raw = if end > start { + render_task_list(&finish_list[start..end]) + } else { + "".to_string() + }; replace_file( PROXMOX_BACKUP_INDEX_TASK_FN,