From 7c22932c64e8104752bb4bd167fb69817e62eb9f Mon Sep 17 00:00:00 2001 From: Dominik Csapak Date: Mon, 4 Apr 2022 13:45:02 +0200 Subject: [PATCH] pbs-client: print error when we couldn't download previous fidx/didx When we have a previous manifest, we try to download the fidx/didx files to get the known chunks list. We continue if that fails (which is ok), but we did not print any error, leading to a confusing backup output, since the users would expect that chunks will be reused. Printing the error should at least make it apparent that something did not work correctly. Signed-off-by: Dominik Csapak --- pbs-client/src/backup_writer.rs | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/pbs-client/src/backup_writer.rs b/pbs-client/src/backup_writer.rs index b02798bd..c81182a7 100644 --- a/pbs-client/src/backup_writer.rs +++ b/pbs-client/src/backup_writer.rs @@ -289,22 +289,28 @@ impl BackupWriter { // try, but ignore errors match ArchiveType::from_path(archive_name) { Ok(ArchiveType::FixedIndex) => { - let _ = self + if let Err(err) = self .download_previous_fixed_index( archive_name, &manifest, known_chunks.clone(), ) - .await; + .await + { + eprintln!("Error downloading .fidx from previous manifest: {}", err); + } } Ok(ArchiveType::DynamicIndex) => { - let _ = self + if let Err(err) = self .download_previous_dynamic_index( archive_name, &manifest, known_chunks.clone(), ) - .await; + .await + { + eprintln!("Error downloading .didx from previous manifest: {}", err); + } } _ => { /* do nothing */ } }