From 6c774660a7bfd89fa76de62a5887e1bd00d605b4 Mon Sep 17 00:00:00 2001 From: Christian Ebner Date: Fri, 4 Apr 2025 15:07:13 +0200 Subject: [PATCH] docs: add description for gc-cache-capacity tuning parameter Adds a bullet point to the listed datastore tuning parameters, describing its functionality, implications and typical values. Signed-off-by: Christian Ebner Link: https://lore.proxmox.com/pbs-devel/20250404130713.376630-4-c.ebner@proxmox.com [TL: address trivial merge conflict from context changes] Signed-off-by: Thomas Lamprecht --- docs/storage.rst | 7 +++++++ www/datastore/OptionView.js | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/docs/storage.rst b/docs/storage.rst index da748c68..2e648b8d 100644 --- a/docs/storage.rst +++ b/docs/storage.rst @@ -451,6 +451,13 @@ There are some tuning related options for the datastore that are more advanced: during phase 2 of garbage collection (given no older writers). If the ``atime`` of the chunk is outside the range, it will be removed. +* ``gc-cache-capacity``: Datastore GC least recently used cache capacity: + Allows to control the cache capacity used to keep track of chunks for which + the access time has already been updated during phase 1 of garbage collection. + This avoids multiple updates and increases GC runtime performance. Higher + values can reduce GC runtime at the cost of increase memory usage, setting the + value to 0 disables caching. + If you want to set multiple tuning options simultaneously, you can separate them with a comma, like this: diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js index de7751e8..c213e753 100644 --- a/www/datastore/OptionView.js +++ b/www/datastore/OptionView.js @@ -301,7 +301,7 @@ Ext.define('PBS.Datastore.Options', { fieldLabel: gettext('GC cache capacity'), emptyText: Proxmox.Utils.defaultText, minValue: 0, - maxValue: 8192 * 1024, + maxValue: 8 * 1024 * 1024, deleteEmpty: true, step: 1024, },