From 61167351a1023ee4fe89d26824886a818fb749ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= Date: Thu, 20 Jul 2023 12:23:56 +0200 Subject: [PATCH] blobs: fix outdated comment about file format MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit the wrong info here was rather misleading, especially when encountering errors just talking about "blobs" when the actual problem is with a chunk. chunks did originally have their own magic values, but that got removed in 4ee8f53d07bf0becf19a22cf4f4674558a4d128c "remove DataChunk file format - use DataBlob instead" back in 2019, before the 0.1.1 release(!) Reported-by: Dominik Csapak Signed-off-by: Fabian Grünbichler --- pbs-datastore/src/file_formats.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pbs-datastore/src/file_formats.rs b/pbs-datastore/src/file_formats.rs index 7e08e530..73d67e20 100644 --- a/pbs-datastore/src/file_formats.rs +++ b/pbs-datastore/src/file_formats.rs @@ -35,8 +35,8 @@ pub const DYNAMIC_SIZED_CHUNK_INDEX_1_0: [u8; 8] = [28, 145, 78, 165, 25, 186, 1 /// /// (MAGIC || CRC32 || Data) /// -/// This is basically the same format we use for chunks, but -/// with other magic numbers so that we can distinguish them. +/// This format is used for blobs (stored in a BackupDir and accessed directly) and chunks (stored +/// in a chunk store and accessed via a ChunkReader / index file). #[derive(Endian)] #[repr(C, packed)] pub struct DataBlobHeader {