proxmox-mirrors/proxmox-backup
1
0
Fork 1
mirror of https://git.proxmox.com/git/proxmox-backup synced 2025-06-14 17:51:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ui: datastore tuning options: increase width and rework labels

Browse Source 
This was getting cramped, and while it might be actually even nicer to
got to more verbose style like we use for advanced settings of backup
jobs in Proxmox VE, with actual sentences describing the options basic
effects and rationale.

But this is way quicker to do and adds already a bit more rationale,
and we can always do more later on when there's less release time
pressure.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2025-04-05 16:30:49 +02:00
parent 4c0583b14e
commit 5e778d983a
2 changed files with 14 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
www/Utils.js
View File

@ -851,12 +851,12 @@ Ext.define('PBS.Utils', {
let gc_atime_safety_check = tuning['gc-atime-safety-check']; let gc_atime_safety_check = tuning['gc-atime-safety-check'];
delete tuning['gc-atime-safety-check']; delete tuning['gc-atime-safety-check'];
options.push(`${gettext('GC Access Time Safety Check')}: ${gc_atime_safety_check ?? true}`); options.push(`${gettext('GC Access-Time Support Check')}: ${gc_atime_safety_check ?? true}`);
let gc_atime_cutoff = tuning['gc-atime-cutoff']; let gc_atime_cutoff = tuning['gc-atime-cutoff'];
delete tuning['gc-atime-cutoff']; delete tuning['gc-atime-cutoff'];
gc_atime_cutoff = gc_atime_cutoff ?? '1445'; gc_atime_cutoff = gc_atime_cutoff ?? '1445';
options.push(`${gettext('GC Access Time Cutoff')}: ${gc_atime_cutoff}m`); options.push(`${gettext('GC Access-Time Cutoff')}: ${gc_atime_cutoff}m`);
let gc_cache_capacity = tuning['gc-cache-capacity']; let gc_cache_capacity = tuning['gc-cache-capacity'];
delete tuning['gc-cache-capacity']; delete tuning['gc-cache-capacity'];

23
www/datastore/OptionView.js
View File

@ -236,7 +236,7 @@ Ext.define('PBS.Datastore.Options', {
xtype: 'proxmoxWindowEdit', xtype: 'proxmoxWindowEdit',
title: gettext('Tuning Options'), title: gettext('Tuning Options'),
onlineHelp: 'datastore_tuning_options', onlineHelp: 'datastore_tuning_options',
width: 350, width: 500,
items: { items: {
xtype: 'inputpanel', xtype: 'inputpanel',
onGetValues: function(values) { onGetValues: function(values) {
@ -258,7 +258,8 @@ Ext.define('PBS.Datastore.Options', {
{ {
xtype: 'proxmoxKVComboBox', xtype: 'proxmoxKVComboBox',
name: 'chunk-order', name: 'chunk-order',
fieldLabel: gettext('Chunk Order'), fieldLabel: gettext('Chunk Iteration Order'),
labelWidth: 200,
comboItems: Object.entries(PBS.Utils.tuningOptions['chunk-order']), comboItems: Object.entries(PBS.Utils.tuningOptions['chunk-order']),
deleteEmpty: true, deleteEmpty: true,
value: '__default__', value: '__default__',
@ -266,7 +267,8 @@ Ext.define('PBS.Datastore.Options', {
{ {
xtype: 'proxmoxKVComboBox', xtype: 'proxmoxKVComboBox',
name: 'sync-level', name: 'sync-level',
fieldLabel: gettext('Sync Level'), fieldLabel: gettext('Data Sync Level'),
labelWidth: 200,
comboItems: Object.entries(PBS.Utils.tuningOptions['sync-level']), comboItems: Object.entries(PBS.Utils.tuningOptions['sync-level']),
deleteEmpty: true, deleteEmpty: true,
value: '__default__', value: '__default__',
@ -274,7 +276,8 @@ Ext.define('PBS.Datastore.Options', {
{ {
xtype: 'proxmoxcheckbox', xtype: 'proxmoxcheckbox',
name: 'gc-atime-safety-check', name: 'gc-atime-safety-check',
fieldLabel: gettext('GC atime Check'), fieldLabel: gettext('GC Access-Time Support Check'),
labelWidth: 200,
autoEl: { autoEl: {
tag: 'div', tag: 'div',
'data-qtip': gettext('Ensure underlying storage honors access time updates'), 'data-qtip': gettext('Ensure underlying storage honors access time updates'),
@ -287,19 +290,17 @@ Ext.define('PBS.Datastore.Options', {
{ {
xtype: 'proxmoxintegerfield', xtype: 'proxmoxintegerfield',
name: 'gc-atime-cutoff', name: 'gc-atime-cutoff',
fieldLabel: gettext('GC Access-Time Cutoff (minutes)'),
labelWidth: 200,
emptyText: gettext('1445 (24 hours 5 minutes)'), emptyText: gettext('1445 (24 hours 5 minutes)'),
fieldLabel: gettext('GC atime Cutoff'),
autoEl: {
tag: 'div',
'data-qtip': gettext('Cutoff for atime in minutes'),
},
deleteEmpty: true, deleteEmpty: true,
}, },
{ {
xtype: 'proxmoxintegerfield', xtype: 'proxmoxintegerfield',
name: 'gc-cache-capacity', name: 'gc-cache-capacity',
fieldLabel: gettext('GC cache capacity'), fieldLabel: gettext('GC Cache Capacity (# chunks)'),
emptyText: Proxmox.Utils.defaultText, labelWidth: 200,
emptyText: gettext('1048576 (0 disables chache)'),
minValue: 0, minValue: 0,
maxValue: 8 * 1024 * 1024, maxValue: 8 * 1024 * 1024,
deleteEmpty: true, deleteEmpty: true,