From 40a2b110bf132bc4021085373d37ca81c493cd15 Mon Sep 17 00:00:00 2001 From: Hannes Laimer Date: Mon, 25 Nov 2024 17:21:54 +0100 Subject: [PATCH] api: add check for nested datastores on creation Signed-off-by: Hannes Laimer --- src/api2/config/datastore.rs | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/src/api2/config/datastore.rs b/src/api2/config/datastore.rs index d4cee458..d6cfdbb0 100644 --- a/src/api2/config/datastore.rs +++ b/src/api2/config/datastore.rs @@ -1,4 +1,4 @@ -use std::path::PathBuf; +use std::path::{Path, PathBuf}; use ::serde::{Deserialize, Serialize}; use anyhow::{bail, format_err, Error}; @@ -81,6 +81,25 @@ pub(crate) fn do_create_datastore( bail!("cannot create datastore in root path"); } + let new_store_path = Path::new(&datastore.path); + for store in config.convert_to_typed_array::("datastore")? { + if store.backing_device != datastore.backing_device { + continue; + } + + // Since we check for that on creation, we assume all removable datastore + // paths are relative, so don't have a leading `/`. + let store_path = Path::new(&store.path); + if store_path.starts_with(&new_store_path) || new_store_path.starts_with(&store_path) { + param_bail!( + "path", + "nested datastores not allowed: '{}' already in '{}'", + store.name, + store.path + ); + } + } + let need_unmount = datastore.backing_device.is_some(); if need_unmount { do_mount_device(datastore.clone())?;