From 3f845414126f6d40ca725fae155a41efd7b2161a Mon Sep 17 00:00:00 2001 From: Stoiko Ivanov Date: Mon, 28 Jun 2021 18:41:09 +0000 Subject: [PATCH] fix #3496: acme: plugin: add sleep for dns propagation the dns plugin config allow for a specified amount of time to wait for the TXT record to be set and propagated through DNS. This patch adds a sleep for this amount of time. The log message was taken from the perl implementation in proxmox-acme for consistency. Tested with the powerdns plugin in my test setup. Signed-off-by: Stoiko Ivanov --- src/acme/plugin.rs | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/acme/plugin.rs b/src/acme/plugin.rs index 0269b9ad..11939cf7 100644 --- a/src/acme/plugin.rs +++ b/src/acme/plugin.rs @@ -2,6 +2,7 @@ use std::future::Future; use std::pin::Pin; use std::process::Stdio; use std::sync::Arc; +use std::time::Duration; use anyhow::{bail, format_err, Error}; use hyper::{Body, Request, Response}; @@ -180,7 +181,21 @@ impl AcmePlugin for DnsPlugin { domain: &'d AcmeDomain, task: Arc, ) -> Pin> + Send + 'fut>> { - Box::pin(self.action(client, authorization, domain, task, "setup")) + Box::pin(async move { + let result = self + .action(client, authorization, domain, task.clone(), "setup") + .await; + let validation_delay = self.core.validation_delay.unwrap_or(30) as u64; + + if validation_delay > 0 { + task.log(format!( + "Sleeping {} seconds to wait for TXT record propagation", + validation_delay + )); + tokio::time::sleep(Duration::from_secs(validation_delay)).await; + } + result + }) } fn teardown<'fut, 'a: 'fut, 'b: 'fut, 'c: 'fut, 'd: 'fut>(