proxmox-mirrors/proxmox-backup
1
0
Fork 1
mirror of https://git.proxmox.com/git/proxmox-backup synced 2025-08-03 09:44:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

file-restore: list: improve pxar v2 performance

Browse Source 
Do not attach the payload reader for split pxar archives, as only the
metadata has to be accessed for listing.
This avoids that the decoder performs consistency checks with the
payload stream, which require chunk download and decoding, making the
listing unusable slow.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
This commit is contained in:
Christian Ebner 2024-06-10 10:39:33 +02:00 committed by Fabian Grünbichler
parent 8834153187
commit 3c9a29e5cf
1 changed files with 3 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
proxmox-file-restore/src/main.rs
View File

@ -170,7 +170,7 @@ async fn list_files(
path = vec![b'/'];
}
let (archive_name, payload_archive_name) =
let (archive_name, _payload_archive_name) =
pbs_client::tools::get_pxar_archive_names(&file, &manifest)?;
let (reader, archive_size) = get_remote_pxar_reader(
@ -181,19 +181,8 @@ async fn list_files(
)
.await?;
let reader = if let Some(payload_archive_name) = payload_archive_name {
let (payload_reader, payload_size) = get_remote_pxar_reader(
&payload_archive_name,
client,
&manifest,
crypt_config,
)
.await?;
pxar::PxarVariant::Split(reader, (payload_reader, payload_size))
} else {
pxar::PxarVariant::Unified(reader)
};
// only care about the metadata, don't attach a payload reader
let reader = pxar::PxarVariant::Unified(reader);
let accessor = Accessor::new(reader, archive_size).await?;
let path = OsStr::from_bytes(&path);