From 3a8d54e81fcfa994ed397e2c120710c3a2302b99 Mon Sep 17 00:00:00 2001 From: Stefan Sterz Date: Fri, 10 Jun 2022 10:13:25 +0200 Subject: [PATCH] config: remove duplicate privilege lookup in cached_user_info `lookup_privs` just uses `lookup_privs_details` but ignores the propagated privileges it returns. thus, the lookup here is redundant as it is immediately followed by a call to `lookup_privs_details` with the same parameters. Signed-off-by: Stefan Sterz --- pbs-config/src/cached_user_info.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/pbs-config/src/cached_user_info.rs b/pbs-config/src/cached_user_info.rs index 8dd2375a..b9534b80 100644 --- a/pbs-config/src/cached_user_info.rs +++ b/pbs-config/src/cached_user_info.rs @@ -170,7 +170,6 @@ impl CachedUserInfo { if auth_id.is_token() { // limit privs to that of owning user let user_auth_id = Authid::from(auth_id.user().clone()); - privs &= self.lookup_privs(&user_auth_id, path); let (owner_privs, owner_propagated_privs) = self.lookup_privs_details(&user_auth_id, path); privs &= owner_privs;