proxmox-mirrors/proxmox-backup
1
0
Fork 1
mirror of https://git.proxmox.com/git/proxmox-backup synced 2025-10-04 18:48:10 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix #5233: don't require root for some tape operations

Browse Source 
instead, require 'Tape.Write' or 'Tape.Modify' on '/tape' path.
This makes it possible for a TapeOperator to destroy tapes and for a
TapeAdmin to update the tape status, instead of just root@pam.

I opted for the path '/tape' since we don't have a dedicated acl
structure for single tapes, just '/tape/pool' (which does not apply
since not all tapes have to have a pool), '/tape/device' (which is
intended for drives/changers) and '/tape/jobs' (which is for jobs only).

Also we use that path for e.g. move_tape already.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
Dominik Csapak 2024-11-13 12:37:42 +01:00 committed by Thomas Lamprecht
parent b3675d867f
commit 2febc83cc0
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/api2/tape/media.rs
View File

@ -9,7 +9,7 @@ use proxmox_uuid::Uuid;
use pbs_api_types::{ use pbs_api_types::{
Authid, MediaContentEntry, MediaContentListFilter, MediaListEntry, MediaPoolConfig, Authid, MediaContentEntry, MediaContentListFilter, MediaListEntry, MediaPoolConfig,
MediaSetListEntry, MediaStatus, CHANGER_NAME_SCHEMA, MEDIA_LABEL_SCHEMA, MediaSetListEntry, MediaStatus, CHANGER_NAME_SCHEMA, MEDIA_LABEL_SCHEMA,
MEDIA_POOL_NAME_SCHEMA, MEDIA_UUID_SCHEMA, PRIV_TAPE_AUDIT, PRIV_TAPE_MODIFY, MEDIA_POOL_NAME_SCHEMA, MEDIA_UUID_SCHEMA, PRIV_TAPE_AUDIT, PRIV_TAPE_MODIFY, PRIV_TAPE_WRITE,
VAULT_NAME_SCHEMA, VAULT_NAME_SCHEMA,
}; };
use pbs_config::CachedUserInfo; use pbs_config::CachedUserInfo;
@ -366,6 +366,9 @@ pub fn move_tape(
}, },
}, },
}, },
access: {
permission: &Permission::Privilege(&["tape"], PRIV_TAPE_WRITE, false),
},
)] )]
/// Destroy media (completely remove from database) /// Destroy media (completely remove from database)
pub fn destroy_media( pub fn destroy_media(
@ -557,6 +560,9 @@ pub fn get_media_status(uuid: Uuid) -> Result<MediaStatus, Error> {
}, },
}, },
}, },
access: {
permission: &Permission::Privilege(&["tape"], PRIV_TAPE_MODIFY, false),
},
)] )]
/// Update media status (None, 'full', 'damaged' or 'retired') /// Update media status (None, 'full', 'damaged' or 'retired')
/// ///