proxmox-mirrors/proxmox-backup
1
0
Fork 1
mirror of https://git.proxmox.com/git/proxmox-backup synced 2025-07-09 16:39:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

remove create & truncate when create_new is used

Browse Source 
As per its documentation [1]:

> If .create_new(true) is set, .create() and .truncate() are ignored.

This gets rid of the "file opened with `create`, but `truncate`
behavior not defined " clippy warnings.

[1] https://doc.rust-lang.org/std/fs/struct.OpenOptions.html#method.create_new

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
This commit is contained in:
Maximiliano Sandoval 2025-01-27 10:24:40 +01:00 committed by Fabian Grünbichler
parent 95d8e70c84
commit 1cf52c6bb3
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pbs-datastore/src/datastore.rs
View File

@ -749,9 +749,9 @@ impl DataStore {
let mut open_options = std::fs::OpenOptions::new(); let mut open_options = std::fs::OpenOptions::new();
open_options.write(true); open_options.write(true);
open_options.truncate(true);
if force { if force {
open_options.truncate(true);
open_options.create(true); open_options.create(true);
} else { } else {
open_options.create_new(true); open_options.create_new(true);

2
proxmox-backup-client/src/main.rs
View File

@ -1598,7 +1598,6 @@ async fn restore(
if let Some(target) = target { if let Some(target) = target {
let mut writer = std::fs::OpenOptions::new() let mut writer = std::fs::OpenOptions::new()
.write(true) .write(true)
.create(true)
.create_new(true) .create_new(true)
.open(target) .open(target)
.map_err(|err| { .map_err(|err| {
@ -1724,7 +1723,6 @@ async fn restore(
let mut writer = if let Some(target) = target { let mut writer = if let Some(target) = target {
std::fs::OpenOptions::new() std::fs::OpenOptions::new()
.write(true) .write(true)
.create(true)
.create_new(true) .create_new(true)
.open(target) .open(target)
.map_err(|err| format_err!("unable to create target file {:?} - {}", target, err))? .map_err(|err| format_err!("unable to create target file {:?} - {}", target, err))?