proxmox-mirrors/proxmox-backup
1
0
Fork 1
mirror of https://git.proxmox.com/git/proxmox-backup synced 2025-08-07 08:03:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: api: avoid race condition in set_backup_owner

Browse Source 
when two clients change the owner of a backup store, a race condition
arose. add locking to avoid this.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
Acked-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
This commit is contained in:
Shannon Sterz 2025-03-26 12:44:14 +01:00 committed by Thomas Lamprecht
parent 52e5d52cbd
commit 04e50855b3
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/api2/admin/datastore.rs
View File

@ -7,7 +7,7 @@ use std::os::unix::ffi::OsStrExt;
use std::path::{Path, PathBuf}; use std::path::{Path, PathBuf};
use std::sync::Arc; use std::sync::Arc;
use anyhow::{bail, format_err, Error}; use anyhow::{bail, format_err, Context, Error};
use futures::*; use futures::*;
use hyper::http::request::Parts; use hyper::http::request::Parts;
use hyper::{header, Body, Response, StatusCode}; use hyper::{header, Body, Response, StatusCode};
@ -2347,10 +2347,9 @@ pub async fn set_backup_owner(
let datastore = DataStore::lookup_datastore(&store, Some(Operation::Write))?; let datastore = DataStore::lookup_datastore(&store, Some(Operation::Write))?;
let backup_group = datastore.backup_group(ns, backup_group); let backup_group = datastore.backup_group(ns, backup_group);
if owner_check_required {
let owner = backup_group.get_owner()?; let owner = backup_group.get_owner()?;
if owner_check_required {
let allowed = match (owner.is_token(), new_owner.is_token()) { let allowed = match (owner.is_token(), new_owner.is_token()) {
(true, true) => { (true, true) => {
// API token to API token, owned by same user // API token to API token, owned by same user
@ -2397,6 +2396,14 @@ pub async fn set_backup_owner(
); );
} }
let _guard = backup_group
.lock()
.with_context(|| format!("while setting the owner of group '{backup_group:?}'"))?;
if owner != backup_group.get_owner()? {
bail!("{owner} does not own this group anymore");
}
backup_group.set_owner(&new_owner, true)?; backup_group.set_owner(&new_owner, true)?;
Ok(()) Ok(())