proxmox-mirrors/proxmox-backup-qemu
1
0
Fork 0
mirror of https://git.proxmox.com/git/proxmox-backup-qemu synced 2025-10-05 03:41:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cleanup: remove stale comments

Browse Source
This commit is contained in:
Dietmar Maurer 2020-07-02 07:34:47 +02:00
parent 9aaaafd7b0
commit 465e5f75e1
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/lib.rs
View File

@ -215,7 +215,7 @@ pub extern "C" fn proxmox_backup_connect(
let callback_info = got_result_condition.callback_info(&mut result, error); let callback_info = got_result_condition.callback_info(&mut result, error);
task.runtime().spawn(async move { // do not use move here???!! task.runtime().spawn(async move {
let result = task.connect().await; let result = task.connect().await;
callback_info.send_result(result); callback_info.send_result(result);
}); });
@ -405,7 +405,7 @@ pub extern "C" fn proxmox_backup_write_data(
let mut got_result_condition = GotResultCondition::new(); let mut got_result_condition = GotResultCondition::new();
let callback_info = got_result_condition.callback_info(&mut result, error); let callback_info = got_result_condition.callback_info(&mut result, error);
let data = DataPointer(data); // fixme let data = DataPointer(data);
task.runtime().spawn(async move { task.runtime().spawn(async move {
let result = task.write_data(dev_id, data, offset, size).await; let result = task.write_data(dev_id, data, offset, size).await;
@ -441,7 +441,7 @@ pub extern "C" fn proxmox_backup_write_data_async(
) { ) {
let task = backup_handle_to_task(handle); let task = backup_handle_to_task(handle);
let callback_info = CallbackPointers { callback, callback_data, error, result }; let callback_info = CallbackPointers { callback, callback_data, error, result };
let data = DataPointer(data); // fixme let data = DataPointer(data);
task.runtime().spawn(async move { task.runtime().spawn(async move {
let result = task.write_data(dev_id, data, offset, size).await; let result = task.write_data(dev_id, data, offset, size).await;
@ -553,7 +553,7 @@ pub extern "C" fn proxmox_backup_finish_async(
#[allow(clippy::not_unsafe_ptr_arg_deref)] #[allow(clippy::not_unsafe_ptr_arg_deref)]
pub extern "C" fn proxmox_backup_disconnect(handle: *mut ProxmoxBackupHandle) { pub extern "C" fn proxmox_backup_disconnect(handle: *mut ProxmoxBackupHandle) {
let task = handle as * mut Arc<BackupTask>; // fixme: why * mut ?? let task = handle as * mut Arc<BackupTask>;
unsafe { Box::from_raw(task) }; // take ownership, drop(task) unsafe { Box::from_raw(task) }; // take ownership, drop(task)
} }

4
src/worker_task.rs
View File

@ -218,8 +218,8 @@ impl BackupTask {
let command_future = finish_backup( let command_future = finish_backup(
writer, writer,
self.registry.clone(), // fixme: pass ref self.registry.clone(),
self.setup.clone(), // fixme: pass ref self.setup.clone(),
); );
let mut abort_rx = self.abort.subscribe(); let mut abort_rx = self.abort.subscribe();
abortable_command(command_future, abort_rx.recv()).await abortable_command(command_future, abort_rx.recv()).await