proxmox-mirrors/proxmox-acme
1
0
Fork 0
mirror of https://git.proxmox.com/git/proxmox-acme synced 2025-05-02 14:35:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Revert "dns-challenge: add 'use-proxy' property"

Browse Source 
a bit to weird of a place to configure this especially as enabling it
does not guarantee any proxying if there's none..

This reverts commit e1088f616f.
This commit is contained in:
Thomas Lamprecht 2021-11-11 10:17:14 +01:00
parent e1088f616f
commit 4ed79f7b4c
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/PVE/ACME/DNSChallenge.pm
View File

@ -56,12 +56,7 @@ sub properties {
optional => 1, optional => 1,
minimum => 0, minimum => 0,
maximum => 2 * 24 * 60 * 60, maximum => 2 * 24 * 60 * 60,
}, }
'use-proxy' => {
description => "Flag indicating whether a http proxy should be used.",
type => 'boolean',
optional => 1,
},
}; };
} }
@ -72,7 +67,6 @@ sub options {
nodes => { optional => 1 }, nodes => { optional => 1 },
disable => { optional => 1 }, disable => { optional => 1 },
'validation-delay' => { optional => 1 }, 'validation-delay' => { optional => 1 },
'use-proxy' => { optional => 1 },
}; };
} }
@ -90,7 +84,6 @@ my $proxmox_acme_command = sub {
my $txtvalue = PVE::ACME::encode(sha256($key_auth)); my $txtvalue = PVE::ACME::encode(sha256($key_auth));
my $dnsplugin = $data->{plugin}->{api}; my $dnsplugin = $data->{plugin}->{api};
my $plugin_conf_string = $data->{plugin}->{data}; my $plugin_conf_string = $data->{plugin}->{data};
my $proxy = $data->{plugin}->{proxy};
# for security reasons, we execute the command as nobody # for security reasons, we execute the command as nobody
# we can't verify that the code of the DNSPlugins are harmless. # we can't verify that the code of the DNSPlugins are harmless.
@ -106,7 +99,6 @@ my $proxmox_acme_command = sub {
} }
my $input = "$txtvalue\n"; my $input = "$txtvalue\n";
$input .= "$plugin_conf_string\n" if $plugin_conf_string; $input .= "$plugin_conf_string\n" if $plugin_conf_string;
$input .= "https_proxy=$proxy\nhttp_proxy=$proxy\n" if $proxy;
PVE::Tools::run_command($cmd, input => $input); PVE::Tools::run_command($cmd, input => $input);