Commit Graph

29 Commits

Author SHA1 Message Date
Stoiko Ivanov
918bfd5b94 rules/object: remove icon from remove button
the icons were introduced to the listing, and it seems their rendering
when removing was not noticed - w/o this the message is e.g.:
"Are you sure you want to remove entry
'<span class="fa-fw fa fa-file-image-o'"></span> Content Type Filter:
..."

Fixes: ea4f2a7 ("add icons to the object types")

Tested-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Friedrich Weber <f.weber@proxmox.com>
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2025-02-21 18:23:08 +01:00
Thomas Lamprecht
ce33f608c6 object groups: consistent add/edit/remove button
Group and separate the actions that create or add new elements from
the ones that edit or remove exiting ones.

Throw in some slight refactoring and code modernization while at it.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2024-02-27 12:56:06 +01:00
Dominik Csapak
758ddf0639 objects: add separator between match field selector and description
Make it easier to see that match-field selector and its description
are separate. For that we have to make the top level docked item a
'toolbar'.

Reported-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2024-02-27 11:45:22 +01:00
Dominik Csapak
107844176f objects: use font-weight for bold text
mdn[0] recommends using `font-weight: bold;` for making the text actually bold
While it has the same effect often, it depends on the font and browser
if the font is rendered bold in a <b> tag.

0: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/b

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2024-02-22 15:37:40 +01:00
Dominik Csapak
1f8397216a objects: don't reload on match mode change
instead update the record of the object list, and update the
visibility of the 'whatWarning'

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2024-02-22 14:55:34 +01:00
Dominik Csapak
e3c8d4fd63 rules/objects: add mode selector dropdown
for objects and object types in rules. We add a simple dropdown for
the 'and' and 'invert' flags, to be somewhat consistent with the
notification matchers from pve and to make the wording more clear than
simple and/invert.

For What matches add a special warning hint, since that behaves a bit
special because of the mail parts.

When the mode changes for an object group, we reload the list of
objects since that holds the info about the attributes, so to avoid
having to keep track in the gui which field changed on the group, we
simply reload the list with the current information.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2024-02-22 14:54:44 +01:00
Dominik Csapak
4703989ab1 fix #4510: add filter box to many grids
namely relay domains, transports, trusted networks, smtp whitelist +
when/what/who object grids.

Adds a new 'FilterField', that takes a store and a list of columns to
filter, and filters on every change.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2024-02-21 17:57:47 +01:00
Thomas Lamprecht
28eb60c0bd eslint fixes
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-10-30 14:08:16 +01:00
Thomas Lamprecht
a36756b058 drop jslint hint for Proxmox global
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-10-23 14:03:17 +02:00
Thomas Lamprecht
c87d46fbe8 tree wide: eslint --fix
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-10-23 13:17:15 +02:00
Dominik Csapak
01e0e5e511 overwrite run_editor of base class
so that every call lands in the custom run_editor

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-06 14:14:26 +02:00
Dominik Csapak
ccbf186ff4 jslint: mixed whitespace
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-10-23 17:33:00 +02:00
Dominik Csapak
ff735274ca jslint: add Proxmox global to files
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-10-23 17:28:56 +02:00
Dominik Csapak
ea4f2a7923 add icons to the object types
and show them in the editwindow, the grid and the add menu

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-10-13 06:29:24 +02:00
Dominik Csapak
8ddd9c44f5 add virusfilter
we now also disable the edit button if the objectgroup editor has an
'uneditable' flag set, we need this, because the virusfilter has nothing
which we could edit

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-10-13 06:21:55 +02:00
Dominik Csapak
7d4f02a370 set button state in load handler instead of callback
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-10-09 13:00:09 +02:00
Dietmar Maurer
69bc007cae ObjectGroup.js - do not overwrite proxy, use monStoreErrors 2017-10-09 08:25:44 +02:00
Dominik Csapak
793ac2e46e remove unnecessary 'new Ext.menu.Menu'
this is implicit when having an object as 'menu' property

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-10-09 06:39:19 +02:00
Dominik Csapak
7a3b5e2d5e jslint: not declared variable, missing semicolon, parseInt base
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-09-28 14:42:24 +02:00
Dominik Csapak
749af0601a jslint: trailing commas
fix many trailing commas

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-09-28 14:41:43 +02:00
Dietmar Maurer
5f3ec152cc implement LDAP group who object 2017-03-23 10:36:35 +01:00
Dietmar Maurer
b357057ee8 use new proxmoxStdRemoveButton widget 2017-03-20 08:02:41 +01:00
Dietmar Maurer
84185bf4e9 ObjectGroupConfiguration.js: fix behaviour when removing entries 2017-03-07 16:51:50 +01:00
Dietmar Maurer
ad834b6f60 improve rule GUI 2017-03-07 11:16:18 +01:00
Dietmar Maurer
cc1c500813 ObjectGroup: fire dblclickOGInfo on double click 2017-03-02 08:09:56 +01:00
Dietmar Maurer
049a531b21 remove SMTPWhitelist, use ObjectGroup instead 2017-03-02 07:23:25 +01:00
Dietmar Maurer
3eba771a8f rename Who to ObjectGroup 2017-03-02 06:50:35 +01:00
Dietmar Maurer
a43acf2e5c rename ObjectGroup to ObjectGroupList 2017-03-02 06:27:21 +01:00
Dietmar Maurer
56b0691b19 implement object group editor - first try 2017-03-01 18:57:08 +01:00