Commit Graph

30 Commits

Author SHA1 Message Date
Stefan Sterz
e950ec7202 quarantines: use a check mark for the dark mode filter
...instead of a toggle button. also adjusts the wording and adds a
separator.

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
2023-03-23 17:19:12 +01:00
Stefan Sterz
9bcb553cfb quarantines: add support for a theme toggle
this allows toggling the presentation of the email previews depending
on the current theme. in the default "light" mode the toggle is hidden
to avoid clutter. enable the toggle in other themes to allow switching
back to the original way the email was rendered.

this requires a bump of the widget toolkit. the toolkit provides the
styles necessary for the toggle to work.

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by:  Dominik Csapak <d.csapak@proxmox.com>
2023-03-15 15:38:54 +01:00
Dominik Csapak
c03e51ed3a fix #3287: add recipient filter for virus & attachment quarantines
So that users can filter these quarantine views, e.g. useful if they
have many mails there.

Replaced the emailSelection config with a quarantineType configs
since we want to have different behaviour for different quaratine
types. E.g., we want to show 'all' mails by default for the
virus/attachment quarantine, but not for the spam one.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2022-11-25 13:31:19 +01:00
Thomas Lamprecht
38229fc877 quarantines: dock attachement grid to bottom, avoid toggle button
A separate header and docked at the bottom reduces crowding at the
top and make the whole view(s) a bit clearer.

This also better mirrors where most mail clients show attachments
(e.g., thunderbird) and allows to avoid the extra button (UX benefits
most of the time from reduced inputs, if it doesn't takes away
features).

Make the panel collapsible for the spam and virus quarantine, and
hide the download button there; note that this isn't done for
security purpose but just wasn't requested and some users may do
better if they only decide deliver/delete here and let their MUA
handle attachements.

Disable collapsing in the Attachement quarantine, it doesn't really
makes sense there and we got a maxHeight already anyway.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-11-07 13:16:51 +01:00
Thomas Lamprecht
ecab0d0e3e attachement grid: set configs used on all use-sites as defaults
avoid overly repetition, we can still override them if we get a use
site that really requires different values here.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-11-07 09:46:31 +01:00
Dominik Csapak
1a96ec322b quarantines: add attachment grid to spam and virus quarantine
So that admins can easily see which attachments exist for a mail,
without parsing the 'raw' mail content. Disable the download button
for these quarantines though, since it should not be necessary
to download the attachments for these.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2022-11-07 09:46:31 +01:00
Dominik Csapak
991d5ec23d fix #2533: quarantine: add overflowHandler to the preview panel
so that the menu can be used even on narrower screens

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2022-11-07 09:46:31 +01:00
Dominik Csapak
4e356bcded quarantine: improve borders for docked items
one cannot set the different borders seperately in panels/grids and
docked items don't have a bottom border in extjs, but we want to remove
all borders except the ones between the toolbar and the grids/content
below that.

to achieve that, set a custom 'border-bottom-width' with '!important'
(extjs has a rule with !important as well) for the toolbar, and
everywhere else remove the border.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2022-11-07 09:46:31 +01:00
Stoiko Ivanov
8fb8931b63 quarantine: use new controller for virus and attachment quarantines
fixes #1674 (the comment about multiselect for the virus quarantine)
fixes #3947 (multiselect for attachment quarantine)

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2022-10-28 11:30:23 +02:00
Thomas Lamprecht
365f84c19b quarantines: color code deliver and delete buttons
In some languages, e.g. widely used English, "Delete" and "Deliver"
are looking rather similar without too much eye squinting required.

Add an accent on their icons using for, at least in the western
hemisphere, the respective associated color, like red for trash can.
To 1) avoid to much messing with those cultures that got it switched
and 2) some more common color blindness use blue for the delivery
button, just to make it stand out.

Keep the white/black list as is, as such accents work best if not
everything uses them, i.e., so that they more common options actually
stand out.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-10-22 16:16:41 +02:00
Thomas Lamprecht
2cc13fbc8a quarantine grids: use arrow function for size renderer
quicker to read and avoids "violating" style guide due to on-line
normal functions

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-10-22 16:14:23 +02:00
Thomas Lamprecht
cd15075876 quarantine: subject/sender: refactor/code-style-fix render functions
extends on the improvements from the previous commit, reduces code
lines while (hopefully, as slightly subjective) not reducing
readability

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-10-22 16:12:25 +02:00
Stoiko Ivanov
ab606ffb7f fix #4137: display receiver in attachment/virus quarantine
the attachment and virus quarantines contain all quarantined mail for
all recipients - so we should display which mail is being
delivered/deleted - mostly if a mail is sent to multiple addresses
served by the same PMG.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2022-10-21 09:28:21 +02:00
Stoiko Ivanov
65c6904285 virusquarantine: fix time format
Ext js orients itself on php's date function, which uses 'i' for
minutes ('m' is the month as integer)[0].

Reported via our community-forum:
https://forum.proxmox.com/threads/time-display-bug-in-virus-quarantine.90816/

Quickly tested on my test-setup

[0] https://docs.sencha.com/extjs/7.0.0/modern/Ext.Date.html
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2021-06-14 10:06:41 +02:00
Dominik Csapak
60a9d6fdbc {Attachment, Spam, Virus}Quarantine: fix layout for iframe
in extjs 7.0 the css changed slightly so that we need to define
the 'fit' layout explicitely to maintain the full width/height

otherwise it can happen that the iframe gets cut off

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-06-08 13:13:54 +00:00
Stoiko Ivanov
a2293354c5 quarantineview: unify url generation
this patch adds the cleanup for the attachment quarantine from
0e26e20aa5 to the virus- and
spamquarantine.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2021-05-11 16:17:05 +02:00
Thomas Lamprecht
f057ca9085 drop jslint hints
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-10-23 14:08:50 +02:00
Thomas Lamprecht
a36756b058 drop jslint hint for Proxmox global
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-10-23 14:03:17 +02:00
Thomas Lamprecht
c87d46fbe8 tree wide: eslint --fix
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-10-23 13:17:15 +02:00
Dominik Csapak
72d8403cb6 Quarantine: set mailinfo visible only on html preview
We did already hide it when toggling raw/html, but when choosing raw
and changing the mail, it was again set to visible.
This patch fixes that by always taking 'me.raw' into account.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-04-15 14:06:43 +02:00
Thomas Lamprecht
4935e8fb22 qurantine: hide mailinfo in raw mode
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-04-15 12:59:38 +02:00
Dominik Csapak
ac6c1fb818 fix #2676: add MailInfo box on Quarantine Views
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-04-14 15:00:33 +02:00
Dietmar Maurer
6265117277 cleanup: set selModel only where we need it 2018-03-29 14:40:32 +02:00
Dominik Csapak
d42f85b806 implement multiselection of spamquarantine mails
and allow the actions to be sent for all simultaniously

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-03-29 14:22:42 +02:00
Dominik Csapak
64fb657f83 improve gettext usage
optimized a few string
EMail/Email/E-mail -> E-Mail
No Data in Database/No data in database. -> No data in database
etc.

removed 'Outlook 2007' from gettext
added some strings to gettext where they were missing
(e.g. Active, etc.)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-01-24 06:26:26 +01:00
Dietmar Maurer
aac17b9be4 Revert "doQuarantineAction: pass pmail parameter"
This reverts commit 794e411a4f.

Not required any longer, because the backend now encode all info inside
the id.
2017-12-28 12:47:11 +01:00
Dietmar Maurer
794e411a4f doQuarantineAction: pass pmail parameter 2017-12-28 08:41:59 +01:00
Dominik Csapak
b76ce2c5f7 jslint: remove unnecessary code, optimize updatePreview
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-10-23 17:31:40 +02:00
Dominik Csapak
56b4528f24 add missing titles for quarantines
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-09-28 15:16:34 +02:00
Dominik Csapak
644f752b75 add VirusQuarantine component
this adds the VirusQuarantine component, which is mostly copied from
the SpamQuarantine but the relevant things changed

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-09-28 14:47:06 +02:00