Commit Graph

19 Commits

Author SHA1 Message Date
Dominik Csapak
e3c8d4fd63 rules/objects: add mode selector dropdown
for objects and object types in rules. We add a simple dropdown for
the 'and' and 'invert' flags, to be somewhat consistent with the
notification matchers from pve and to make the wording more clear than
simple and/invert.

For What matches add a special warning hint, since that behaves a bit
special because of the mail parts.

When the mode changes for an object group, we reload the list of
objects since that holds the info about the attributes, so to avoid
having to keep track in the gui which field changed on the group, we
simply reload the list with the current information.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2024-02-22 14:54:44 +01:00
Dominik Csapak
60875e2d74 rules: use tree panel instead of grouping feature of the grid
just in preparation for adding a column for the groups
will look similar (though not identical) to before, but this makes
the groups now real entries in the grid, which means we can have
content in additional columns

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2024-02-22 14:54:16 +01:00
Leo Nunner
df2a647a72 mail filter: properly html-encode rule names
Rule names were not HTML-encoded in the rule overview. While some
encoding did happen, it was only on the first load for the info panel
on the right hand side, which was overriden as soon as the edit
window was opened/closed again.

The variable binding now gets HTML-encoded automatically, and the
renderer for rule names has been set to Ext.htmlEncode.

Signed-off-by: Leo Nunner <l.nunner@proxmox.com>
 [ T: rework commit message a bit (mostly subject) ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-05-17 12:01:35 +02:00
Thomas Lamprecht
f057ca9085 drop jslint hints
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-10-23 14:08:50 +02:00
Thomas Lamprecht
a36756b058 drop jslint hint for Proxmox global
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-10-23 14:03:17 +02:00
Thomas Lamprecht
c87d46fbe8 tree wide: eslint --fix
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-10-23 13:17:15 +02:00
Dominik Csapak
64fb657f83 improve gettext usage
optimized a few string
EMail/Email/E-mail -> E-Mail
No Data in Database/No data in database. -> No data in database
etc.

removed 'Outlook 2007' from gettext
added some strings to gettext where they were missing
(e.g. Active, etc.)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-01-24 06:26:26 +01:00
Dominik Csapak
4a1b15b9d7 fix removal of rules
setting a non-object to undefined is not designed to be done
in a viewmodel

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-11-10 17:29:08 +01:00
Dominik Csapak
7a3b5e2d5e jslint: not declared variable, missing semicolon, parseInt base
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-09-28 14:42:24 +02:00
Dominik Csapak
ea07c9aa8e jslint: type confusion
fix many type confusions

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-09-28 14:42:13 +02:00
Dominik Csapak
749af0601a jslint: trailing commas
fix many trailing commas

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-09-28 14:41:43 +02:00
Dominik Csapak
2c1d504e90 jslint: globals
adds the global object proxmox to most files

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-09-28 14:41:31 +02:00
Dominik Csapak
1f6397682a remove action text and resize column
this looks better and has not the confusing name "actions"

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-04-05 11:29:18 +02:00
Dominik Csapak
2b97521b65 change x-fa to fa
because there is no x-fa class when using the stock fontawesome css

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-04-05 11:28:51 +02:00
Dominik Csapak
c3339ea165 rewrite ruleinfo
complete rewrite of the ruleinfo sidebar

* uses mvvm system
* show tabpanel with all unused objects, each category in a tab
* group the used objects by type
* allow for drag/drop or the actionbuttons for adding/removing

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-04-05 06:48:11 +02:00
Dietmar Maurer
b357057ee8 use new proxmoxStdRemoveButton widget 2017-03-20 08:02:41 +01:00
Dietmar Maurer
397006117a rename ActionConfiguration.js to ActionList.js
And use it to edit rules.
2017-03-07 12:37:18 +01:00
Dietmar Maurer
f71626c2c7 ObjectGroupSelector.js: new widget to simplify code 2017-03-07 12:09:23 +01:00
Dietmar Maurer
ad834b6f60 improve rule GUI 2017-03-07 11:16:18 +01:00