when we target the quarantine view, we don't want to show the realm
field, since the only valid users here are from LDAP and that is not a
realm in that sense.
We do this by moving the realmfield hide/disable up before the
autologin, but after the targetview check.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
record here can also be 'null', so it's not enough to check for
undefined. While at it, change the statement to conform to our style
guide.
This also fixes the quarantine link popup, because an exception in
a change handler interrupts normal extjs operation, which leads
to an invalid extjs state here.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
In particular, align the descriptions for whitelist/blacklist and
avoid referring to the rather unspecific "the mail" and
"the messages" there.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Reviewed-By: Alexander Zeidler <a.zeidler@proxmox.com>
Make the realm configuration available in PMG and disable LDAP/AD
realms for now and use the name oidc instead of openid.
Signed-off-by: Markus Frank <m.frank@proxmox.com>
By adding a viewModel with an oidc variable, the username & password
fields are disabled/hidden when an OIDC realm is selected.
Signed-off-by: Markus Frank <m.frank@proxmox.com>
It seems the 'grow' feature of the textarea only works properly on user
input, not when automatically filling it with data. So instead of trying
to do that, which only ever clipped the record if it was too large,
simply use a fixed size that is enough for 4096 bit sized keys and show
a scrollbar for larger ones.
With having a fixed height, and horizontal resizing a textarea also not
working properly in an edit window, prevent the whole window from
resizing.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
To avoid visual glitches that can happen if a text value is wrongly
interpreted as html. And while quite a few rows already had a rather
restricted format that avoided this in the first place it still
doesn't hurt to encode anyway, that also protects against the case
where a backend format becomes less restrictive in the future.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Line-count increases but that small cost is easily covered by easier
to read code and better git change tracking, which is shown line-wise
by default.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Since the value of the 'admin-mail-from' field has normally a format
like "Full Name <some@email.example>" the <..> part would be
incorrectly interpreted as HTML without encoding it, causing visual
glitches here.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Use the semantic html kbd tag [0] for the keyboard short cut and style
it color-scheme agnostic, which was adapted from the style we use in
our PVE wiki.
[0]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/kbd
Additionally to some small rewording and touch up of the text and
slightly increase the font-size.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Having a short explanation of what the quarantine interface provides,
in the end-user interface should help users who wonder why they get
mails from some system, and what quarantine means. Instead of adding
this to the regular documentation and linking it in the top-bar as we
do in the admin-view having a short description directly rendered on
the main panel should increase the chances of it getting read.
the code is inspired by the notesview (I found it when clicking
through a PBS system of mine looking for how to address this).
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
the icons were introduced to the listing, and it seems their rendering
when removing was not noticed - w/o this the message is e.g.:
"Are you sure you want to remove entry
'<span class="fa-fw fa fa-file-image-o'"></span> Content Type Filter:
..."
Fixes: ea4f2a7 ("add icons to the object types")
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Friedrich Weber <f.weber@proxmox.com>
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
users that add the correct subscription key just get unnecessarily
confused with a "value does not match the regex pattern" error if
they accidentally have a stray whitespace at the end or beginning
otherwise.
Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
Move the buttons for applying or reverting pending changes into the
top bar of the pending changes diff panel, as then they are closer to
what they control and also only shown when relevant.
Drop the odd hint w.r.t. restarting pmg-smtp-filter from the top-bar,
as we can convey that better in the prompt, where there is already a
check-box that defaults to restarting that service.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Group and separate the actions that create or add new elements from
the ones that edit or remove exiting ones.
Throw in some slight refactoring and code modernization while at it.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Make it easier to see that match-field selector and its description
are separate. For that we have to make the top level docked item a
'toolbar'.
Reported-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
not only five, as with the higher panels we already got enough space,
as one row needs roughly 24 px, lower top/bottom padding a bit to get
~242 of space, fitting ten entries nicely.
The performance aspect should not matter much, getting five or ten
entries from a DB like PostgreSQL is really not costing much,
especially as with the count query in use the hard work has already
been done anyway.
Makes the top-receiver panel look a bit more coherent compared to the
node info one beside it.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Now that the node info one got another row we can use a bit more space
to avoid that it feels to crammed.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Add a extra row for showing the current boot mode, for that we need to
grow the height of the status panel and graphs to have enough space
again.
Mirrors commit 1f1d8bf3 ("ui: node summary: add boot-mode
information") from pve-manager.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
use the new 'current-kernel' object returned by the node status API to
render a more usable (less noise) version information.
Keep fallback for old one to better work with upgrades (major and
minor) to this version in a cluster, where the web UI one uses might
be the new one, but a node one looks at still have the old API daemon.
Mirrors commit be04f8ee ("ui: node summary: reduce noise in current
kernel version") and commit 4fb7e9e4 ("fix #5121: ui: node status:
avoid invalid array access for certain foreign kernels") from
pve-manager.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
for controlling if the separator should be included or not, default is
on (backend default).
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
[ TL: explicitly submit unchecked value ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
mdn[0] recommends using `font-weight: bold;` for making the text actually bold
While it has the same effect often, it depends on the font and browser
if the font is rendered bold in a <b> tag.
0: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/b
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
instead update the record of the object list, and update the
visibility of the 'whatWarning'
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
for objects and object types in rules. We add a simple dropdown for
the 'and' and 'invert' flags, to be somewhat consistent with the
notification matchers from pve and to make the wording more clear than
simple and/invert.
For What matches add a special warning hint, since that behaves a bit
special because of the mail parts.
When the mode changes for an object group, we reload the list of
objects since that holds the info about the attributes, so to avoid
having to keep track in the gui which field changed on the group, we
simply reload the list with the current information.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
just in preparation for adding a column for the groups
will look similar (though not identical) to before, but this makes
the groups now real entries in the grid, which means we can have
content in additional columns
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
namely relay domains, transports, trusted networks, smtp whitelist +
when/what/who object grids.
Adds a new 'FilterField', that takes a store and a list of columns to
filter, and filters on every change.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
