From c15e1e14564d72fc310481631ebee4dbe7db47a7 Mon Sep 17 00:00:00 2001
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
Date: Fri, 25 Feb 2022 15:45:56 +0100
Subject: [PATCH] macro: add a write attribute to packages

the .pm file now gets written if either 'write=true' or
'file' is set, setting just 'lib' won't trigger a write
anymore

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
---
 perlmod-macro/src/attribs.rs | 14 ++++++++++++++
 perlmod-macro/src/module.rs  |  4 ++--
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/perlmod-macro/src/attribs.rs b/perlmod-macro/src/attribs.rs
index 35e61f9..1f6edfc 100644
--- a/perlmod-macro/src/attribs.rs
+++ b/perlmod-macro/src/attribs.rs
@@ -7,6 +7,7 @@ pub struct ModuleAttrs {
     pub package_name: String,
     pub file_name: Option<String>,
     pub lib_name: Option<String>,
+    pub write: Option<bool>,
 }
 
 fn is_ident_check_dup<T>(path: &syn::Path, var: &Option<T>, what: &'static str) -> bool {
@@ -27,6 +28,7 @@ impl TryFrom<AttributeArgs> for ModuleAttrs {
         let mut package_name = None;
         let mut file_name = None;
         let mut lib_name = None;
+        let mut write = None;
 
         for arg in args {
             match arg {
@@ -45,6 +47,17 @@ impl TryFrom<AttributeArgs> for ModuleAttrs {
                         error!(path => "unknown argument");
                     }
                 }
+                syn::NestedMeta::Meta(syn::Meta::NameValue(syn::MetaNameValue {
+                    path,
+                    lit: syn::Lit::Bool(litbool),
+                    ..
+                })) => {
+                    if is_ident_check_dup(&path, &write, "write") {
+                        write = Some(litbool.value());
+                    } else {
+                        error!(path => "unknown argument");
+                    }
+                }
                 _ => error!(Span::call_site(), "unexpected attribute argument"),
             }
         }
@@ -56,6 +69,7 @@ impl TryFrom<AttributeArgs> for ModuleAttrs {
             package_name,
             file_name,
             lib_name,
+            write,
         })
     }
 }
diff --git a/perlmod-macro/src/module.rs b/perlmod-macro/src/module.rs
index 6df7928..9b5843f 100644
--- a/perlmod-macro/src/module.rs
+++ b/perlmod-macro/src/module.rs
@@ -68,8 +68,8 @@ pub fn handle_module(attr: AttributeArgs, mut module: syn::ItemMod) -> Result<To
         items.push(syn::Item::Verbatim(package.bootstrap_function()));
     }
 
-    if package.attrs.file_name.is_some()
-        || package.attrs.lib_name.is_some()
+    if package.attrs.write == Some(true)
+        || package.attrs.file_name.is_some()
         || std::env::var("PERLMOD_WRITE_PACKAGES").ok().as_deref() == Some("1")
     {
         package.write()?;