mirror of
https://git.proxmox.com/git/mirror_zfs
synced 2025-10-25 07:17:03 +00:00
a73f361fdb
This feature allows copying existing bookmarks using
zfs bookmark fs#target fs#newbookmark
There are some niche use cases for such functionality,
e.g. when using bookmarks as markers for replication progress.
Copying redaction bookmarks produces a normal bookmark that
cannot be used for redacted send (we are not duplicating
the redaction object).
ZCP support for bookmarking (both creation and copying) will be
implemented in a separate patch based on this work.
Overview:
- Terminology:
- source = existing snapshot or bookmark
- new/bmark = new bookmark
- Implement bookmark copying in `dsl_bookmark.c`
- create new bookmark node
- copy source's `zbn_phys` to new's `zbn_phys`
- zero-out redaction object id in copy
- Extend existing bookmark ioctl nvlist schema to accept
bookmarks as sources
- => `dsl_bookmark_create_nvl_validate` is authoritative
- use `dsl_dataset_is_before` check for both snapshot
and bookmark sources
- Adjust CLI
- refactor shortname expansion logic in `zfs_do_bookmark`
- Update man pages
- warn about redaction bookmark handling
- Add test cases
- CLI
- pyyzfs libzfs_core bindings
Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed-by: Paul Dagnelie <pcd@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Christian Schwarz <me@cschwarz.com>
Closes #9571
72 lines
2.5 KiB
C
72 lines
2.5 KiB
C
/*
|
|
* CDDL HEADER START
|
|
*
|
|
* The contents of this file are subject to the terms of the
|
|
* Common Development and Distribution License (the "License").
|
|
* You may not use this file except in compliance with the License.
|
|
*
|
|
* You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
|
|
* or http://www.opensolaris.org/os/licensing.
|
|
* See the License for the specific language governing permissions
|
|
* and limitations under the License.
|
|
*
|
|
* When distributing Covered Code, include this CDDL HEADER in each
|
|
* file and include the License file at usr/src/OPENSOLARIS.LICENSE.
|
|
* If applicable, add the following below this CDDL HEADER, with the
|
|
* fields enclosed by brackets "[]" replaced with your own identifying
|
|
* information: Portions Copyright [yyyy] [name of copyright owner]
|
|
*
|
|
* CDDL HEADER END
|
|
*/
|
|
/*
|
|
* Copyright 2009 Sun Microsystems, Inc. All rights reserved.
|
|
* Use is subject to license terms.
|
|
*/
|
|
/*
|
|
* Copyright (c) 2013, 2016 by Delphix. All rights reserved.
|
|
*/
|
|
|
|
#ifndef _ZFS_NAMECHECK_H
|
|
#define _ZFS_NAMECHECK_H
|
|
|
|
#ifdef __cplusplus
|
|
extern "C" {
|
|
#endif
|
|
|
|
typedef enum {
|
|
NAME_ERR_LEADING_SLASH, /* name begins with leading slash */
|
|
NAME_ERR_EMPTY_COMPONENT, /* name contains an empty component */
|
|
NAME_ERR_TRAILING_SLASH, /* name ends with a slash */
|
|
NAME_ERR_INVALCHAR, /* invalid character found */
|
|
NAME_ERR_MULTIPLE_DELIMITERS, /* multiple '@'/'#' delimiters found */
|
|
NAME_ERR_NOLETTER, /* pool doesn't begin with a letter */
|
|
NAME_ERR_RESERVED, /* entire name is reserved */
|
|
NAME_ERR_DISKLIKE, /* reserved disk name (c[0-9].*) */
|
|
NAME_ERR_TOOLONG, /* name is too long */
|
|
NAME_ERR_SELF_REF, /* reserved self path name ('.') */
|
|
NAME_ERR_PARENT_REF, /* reserved parent path name ('..') */
|
|
NAME_ERR_NO_AT, /* permission set is missing '@' */
|
|
NAME_ERR_NO_POUND, /* permission set is missing '#' */
|
|
} namecheck_err_t;
|
|
|
|
#define ZFS_PERMSET_MAXLEN 64
|
|
|
|
extern int zfs_max_dataset_nesting;
|
|
|
|
int get_dataset_depth(const char *);
|
|
int pool_namecheck(const char *, namecheck_err_t *, char *);
|
|
int entity_namecheck(const char *, namecheck_err_t *, char *);
|
|
int dataset_namecheck(const char *, namecheck_err_t *, char *);
|
|
int snapshot_namecheck(const char *, namecheck_err_t *, char *);
|
|
int bookmark_namecheck(const char *, namecheck_err_t *, char *);
|
|
int dataset_nestcheck(const char *);
|
|
int mountpoint_namecheck(const char *, namecheck_err_t *);
|
|
int zfs_component_namecheck(const char *, namecheck_err_t *, char *);
|
|
int permset_namecheck(const char *, namecheck_err_t *, char *);
|
|
|
|
#ifdef __cplusplus
|
|
}
|
|
#endif
|
|
|
|
#endif /* _ZFS_NAMECHECK_H */
|