mirror of
				https://git.proxmox.com/git/mirror_zfs
				synced 2025-11-04 01:41:27 +00:00 
			
		
		
		
	Parts of the Linux kernel build system struggle with _Noreturn.  This
results in the following warnings when building on RHEL 8.5, and likely
other environments.  Switch to using the __attribute__((noreturn)).
  warning: objtool: dbuf_free_range()+0x2b8:
    return with modified stack frame
  warning: objtool: dbuf_free_range()+0x0:
    stack state mismatch: cfa1=7+40 cfa2=7+8
  ...
  WARNING: EXPORT symbol "arc_buf_size" [zfs.ko] version generation
    failed, symbol will not be versioned.
  WARNING: EXPORT symbol "spa_open" [zfs.ko] version generation
    failed, symbol will not be versioned.
  ...
Additionally, __thread_exit() has been renamed spl_thread_exit() and
made a static inline function.  This was needed because the kernel
will generate a warning for symbols which are __attribute__((noreturn))
and then exported with EXPORT_SYMBOL.
While we could continue to use _Noreturn in user space I've also
switched it to __attribute__((noreturn)) purely for consistency
throughout the code base.
Reviewed-by: Ryan Moeller <freqlabs@FreeBSD.org>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #13238
		
	
			
		
			
				
	
	
		
			91 lines
		
	
	
		
			2.6 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			91 lines
		
	
	
		
			2.6 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 *  Copyright (C) 2007-2010 Lawrence Livermore National Security, LLC.
 | 
						|
 *  Copyright (C) 2007 The Regents of the University of California.
 | 
						|
 *  Produced at Lawrence Livermore National Laboratory (cf, DISCLAIMER).
 | 
						|
 *  Written by Brian Behlendorf <behlendorf1@llnl.gov>.
 | 
						|
 *  UCRL-CODE-235197
 | 
						|
 *
 | 
						|
 *  This file is part of the SPL, Solaris Porting Layer.
 | 
						|
 *
 | 
						|
 *  The SPL is free software; you can redistribute it and/or modify it
 | 
						|
 *  under the terms of the GNU General Public License as published by the
 | 
						|
 *  Free Software Foundation; either version 2 of the License, or (at your
 | 
						|
 *  option) any later version.
 | 
						|
 *
 | 
						|
 *  The SPL is distributed in the hope that it will be useful, but WITHOUT
 | 
						|
 *  ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 | 
						|
 *  FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
 | 
						|
 *  for more details.
 | 
						|
 *
 | 
						|
 *  You should have received a copy of the GNU General Public License along
 | 
						|
 *  with the SPL.  If not, see <http://www.gnu.org/licenses/>.
 | 
						|
 */
 | 
						|
 | 
						|
#ifndef _SPL_THREAD_H
 | 
						|
#define	_SPL_THREAD_H
 | 
						|
 | 
						|
#include <linux/module.h>
 | 
						|
#include <linux/mm.h>
 | 
						|
#include <linux/spinlock.h>
 | 
						|
#include <linux/kthread.h>
 | 
						|
#include <sys/types.h>
 | 
						|
#include <sys/sysmacros.h>
 | 
						|
#include <sys/tsd.h>
 | 
						|
 | 
						|
/*
 | 
						|
 * Thread interfaces
 | 
						|
 */
 | 
						|
#define	TP_MAGIC			0x53535353
 | 
						|
 | 
						|
#define	TS_SLEEP			TASK_INTERRUPTIBLE
 | 
						|
#define	TS_RUN				TASK_RUNNING
 | 
						|
#define	TS_ZOMB				EXIT_ZOMBIE
 | 
						|
#define	TS_STOPPED			TASK_STOPPED
 | 
						|
 | 
						|
typedef void (*thread_func_t)(void *);
 | 
						|
 | 
						|
#define	thread_create_named(name, stk, stksize, func, arg, len,	\
 | 
						|
    pp, state, pri)	\
 | 
						|
	__thread_create(stk, stksize, (thread_func_t)func,		\
 | 
						|
	name, arg, len, pp, state, pri)
 | 
						|
 | 
						|
#define	thread_create(stk, stksize, func, arg, len, pp, state, pri)	\
 | 
						|
	__thread_create(stk, stksize, (thread_func_t)func, #func,	\
 | 
						|
	arg, len, pp, state, pri)
 | 
						|
 | 
						|
#define	thread_exit()			spl_thread_exit()
 | 
						|
#define	thread_join(t)			VERIFY(0)
 | 
						|
#define	curthread			current
 | 
						|
#define	getcomm()			current->comm
 | 
						|
#define	getpid()			current->pid
 | 
						|
 | 
						|
extern kthread_t *__thread_create(caddr_t stk, size_t  stksize,
 | 
						|
    thread_func_t func, const char *name, void *args, size_t len, proc_t *pp,
 | 
						|
    int state, pri_t pri);
 | 
						|
extern struct task_struct *spl_kthread_create(int (*func)(void *),
 | 
						|
    void *data, const char namefmt[], ...);
 | 
						|
 | 
						|
static inline __attribute__((noreturn)) void
 | 
						|
spl_thread_exit(void)
 | 
						|
{
 | 
						|
	tsd_exit();
 | 
						|
	SPL_KTHREAD_COMPLETE_AND_EXIT(NULL, 0);
 | 
						|
}
 | 
						|
 | 
						|
extern proc_t p0;
 | 
						|
 | 
						|
#ifdef HAVE_SIGINFO
 | 
						|
typedef kernel_siginfo_t spl_kernel_siginfo_t;
 | 
						|
#else
 | 
						|
typedef siginfo_t spl_kernel_siginfo_t;
 | 
						|
#endif
 | 
						|
 | 
						|
#ifdef HAVE_SET_SPECIAL_STATE
 | 
						|
#define	spl_set_special_state(x) set_special_state((x))
 | 
						|
#else
 | 
						|
#define	spl_set_special_state(x) __set_current_state((x))
 | 
						|
#endif
 | 
						|
 | 
						|
 | 
						|
#endif  /* _SPL_THREAD_H */
 |