From 951a3889d19925fb75bd0bfaac0dce6767e2e0a4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=D0=BD=D0=B0=D0=B1?= <nabijaczleweli@nabijaczleweli.xyz>
Date: Tue, 3 May 2022 15:40:34 +0200
Subject: [PATCH] tests: many_fds: simplify, modernise
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #13411
---
 .../tests/functional/libzfs/many_fds.c        | 54 +++++++------------
 1 file changed, 20 insertions(+), 34 deletions(-)

diff --git a/tests/zfs-tests/tests/functional/libzfs/many_fds.c b/tests/zfs-tests/tests/functional/libzfs/many_fds.c
index 6def57c5a..34029e0e3 100644
--- a/tests/zfs-tests/tests/functional/libzfs/many_fds.c
+++ b/tests/zfs-tests/tests/functional/libzfs/many_fds.c
@@ -22,15 +22,13 @@
 /*
  * Copyright (C) 2015 STRATO AG.
  */
-#include <stdlib.h>
-#include <stdio.h>
-#include <unistd.h>
-#include <sys/types.h>
-#include <sys/stat.h>
+#include <err.h>
 #include <fcntl.h>
 #include <libzfs.h>
 #include <sys/resource.h>
-#include <errno.h>
+#include <sys/stat.h>
+#include <sys/types.h>
+#include <unistd.h>
 
 /*
  * Check if libzfs works with more than 255 held file handles.
@@ -38,35 +36,23 @@
 int
 main(void)
 {
-	int i;
-	struct rlimit limit;
-	libzfs_handle_t *h;
+	struct rlimit limit = {
+		.rlim_cur = 64 * 1024,
+		.rlim_max = 64 * 1024,
+	};
+	if (setrlimit(RLIMIT_NOFILE, &limit) != 0)
+		err(1, "setrlimit()");
 
-	limit.rlim_cur = 65535;
-	limit.rlim_max = 65535;
+	int fd = open("/dev/null", O_RDONLY);
+	if (fd == -1)
+			err(1, "open()");
+	for (int i = 0; i < limit.rlim_cur / 2; ++i)
+		if (dup(fd) == -1)
+			err(1, "dup()");
 
-	if (setrlimit(RLIMIT_NOFILE, &limit) != 0) {
-		(void) printf("many_fds: setrlimit() failed with errno=%d\n",
-		    errno);
-		exit(1);
-	}
+	libzfs_handle_t *h = libzfs_init();
+	if (h == NULL)
+		err(1, "libzfs_init()");
 
-	for (i = 0; i < 255; ++i) {
-		int fd = open("/dev/null", O_RDONLY);
-		if (fd == -1) {
-			(void) printf("open failed with errno=%d\n", errno);
-			return (1);
-		}
-	}
-
-	h = libzfs_init();
-
-	if (h != NULL) {
-		libzfs_fini(h);
-		return (0);
-	} else {
-		(void) printf("many_fds: libzfs_init() failed with errno=%d\n",
-		    errno);
-		return (1);
-	}
+	libzfs_fini(h);
 }