From 77a405ae52e4a902f7cc3790e2a73d044c66d962 Mon Sep 17 00:00:00 2001 From: Brian Behlendorf Date: Wed, 14 Mar 2012 12:36:49 -0700 Subject: [PATCH] Add missing NULL in zpl_xattr_handlers The xattr_resolve_name() helper function expects the registered list of xattr handlers to be NULL terminated. This NULL was accidentally missing which could result in a NULL dereference. Interestingly this issue only manifested itself on certain 32-bit systems. Presumably on 64-bit kernels we just always happen to get lucky and the memory following the structure is zeroed. Signed-off-by: Brian Behlendorf Issue #594 --- module/zfs/zpl_xattr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/module/zfs/zpl_xattr.c b/module/zfs/zpl_xattr.c index dbe61df98..c03764fc5 100644 --- a/module/zfs/zpl_xattr.c +++ b/module/zfs/zpl_xattr.c @@ -674,4 +674,5 @@ xattr_handler_t *zpl_xattr_handlers[] = { &zpl_xattr_acl_access_handler, &zpl_xattr_acl_default_handler, #endif /* HAVE_POSIX_ACLS */ + NULL };