mirror_ubuntu-kernels/drivers/net/ethernet/intel
Magnus Karlsson ed0907e3bd ice: fix napi work done reporting in xsk path
Fix the wrong napi work done reporting in the xsk path of the ice
driver. The code in the main Rx processing loop was written to assume
that the buffer allocation code returns true if all allocations where
successful and false if not. In contrast with all other Intel NIC xsk
drivers, the ice_alloc_rx_bufs_zc() has the inverted logic messing up
the work done reporting in the napi loop.

This can be fixed either by inverting the return value from
ice_alloc_rx_bufs_zc() in the function that uses this in an incorrect
way, or by changing the return value of ice_alloc_rx_bufs_zc(). We
chose the latter as it makes all the xsk allocation functions for
Intel NICs behave in the same way. My guess is that it was this
unexpected discrepancy that gave rise to this bug in the first place.

Fixes: 5bb0c4b5eb ("ice, xsk: Move Rx allocation out of while-loop")
Reported-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
Tested-by: Kiran Bhandare <kiranx.bhandare@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2021-03-12 07:43:46 -08:00
..
e1000 e1000: drop unneeded assignment in e1000_set_itr() 2021-02-03 16:32:18 -08:00
e1000e e1000e: Fix error handling in e1000_set_d0_lplu_state_82571 2021-03-11 09:37:48 -08:00
fm10k net: use the new dev_page_is_reusable() instead of private versions 2021-02-04 18:20:14 -08:00
i40e Merge branch '40GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue 2021-02-22 19:14:48 -08:00
iavf net: intel: iavf: fix error return code of iavf_init_get_resources() 2021-03-05 12:59:32 -08:00
ice ice: fix napi work done reporting in xsk path 2021-03-12 07:43:46 -08:00
igb Merge branch '1GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue 2021-02-04 21:26:28 -08:00
igbvf net: igbvf: use skb_csum_is_sctp instead of protocol check 2021-01-19 14:31:25 -08:00
igc igc: Fix igc_ptp_rx_pktstamp() 2021-03-11 09:37:48 -08:00
ixgb
ixgbe ixgbe: Fix memleak in ixgbe_configure_clsu32 2021-03-04 11:05:06 -08:00
ixgbevf ixgbe: fail to create xfrm offload of IPsec tunnel mode SA 2021-03-04 11:05:05 -08:00
e100.c e100: switch from 'pci_' to 'dma_' API 2021-01-28 18:31:18 -08:00
Kconfig
Makefile