Kevin Hao e5c6b312ce cpufreq: schedutil: Use kobject release() method to free sugov_tunables ... The struct sugov_tunables is protected by the kobject, so we can't free it directly. Otherwise we would get a call trace like this: ODEBUG: free active (active state 0) object type: timer_list hint: delayed_work_timer_fn+0x0/0x30 WARNING: CPU: 3 PID: 720 at lib/debugobjects.c:505 debug_print_object+0xb8/0x100 Modules linked in: CPU: 3 PID: 720 Comm: a.sh Tainted: G W 5.14.0-rc1-next-20210715-yocto-standard+ #507 Hardware name: Marvell OcteonTX CN96XX board (DT) pstate: 40400009 (nZcv daif +PAN -UAO -TCO BTYPE=--) pc : debug_print_object+0xb8/0x100 lr : debug_print_object+0xb8/0x100 sp : ffff80001ecaf910 x29: ffff80001ecaf910 x28: ffff00011b10b8d0 x27: ffff800011043d80 x26: ffff00011a8f0000 x25: ffff800013cb3ff0 x24: 0000000000000000 x23: ffff80001142aa68 x22: ffff800011043d80 x21: ffff00010de46f20 x20: ffff800013c0c520 x19: ffff800011d8f5b0 x18: 0000000000000010 x17: 6e6968207473696c x16: 5f72656d6974203a x15: 6570797420746365 x14: 6a626f2029302065 x13: 303378302f307830 x12: 2b6e665f72656d69 x11: ffff8000124b1560 x10: ffff800012331520 x9 : ffff8000100ca6b0 x8 : 000000000017ffe8 x7 : c0000000fffeffff x6 : 0000000000000001 x5 : ffff800011d8c000 x4 : ffff800011d8c740 x3 : 0000000000000000 x2 : ffff0001108301c0 x1 : ab3c90eedf9c0f00 x0 : 0000000000000000 Call trace: debug_print_object+0xb8/0x100 __debug_check_no_obj_freed+0x1c0/0x230 debug_check_no_obj_freed+0x20/0x88 slab_free_freelist_hook+0x154/0x1c8 kfree+0x114/0x5d0 sugov_exit+0xbc/0xc0 cpufreq_exit_governor+0x44/0x90 cpufreq_set_policy+0x268/0x4a8 store_scaling_governor+0xe0/0x128 store+0xc0/0xf0 sysfs_kf_write+0x54/0x80 kernfs_fop_write_iter+0x128/0x1c0 new_sync_write+0xf0/0x190 vfs_write+0x2d4/0x478 ksys_write+0x74/0x100 __arm64_sys_write+0x24/0x30 invoke_syscall.constprop.0+0x54/0xe0 do_el0_svc+0x64/0x158 el0_svc+0x2c/0xb0 el0t_64_sync_handler+0xb0/0xb8 el0t_64_sync+0x198/0x19c irq event stamp: 5518 hardirqs last enabled at (5517): [<ffff8000100cbd7c>] console_unlock+0x554/0x6c8 hardirqs last disabled at (5518): [<ffff800010fc0638>] el1_dbg+0x28/0xa0 softirqs last enabled at (5504): [<ffff8000100106e0>] __do_softirq+0x4d0/0x6c0 softirqs last disabled at (5483): [<ffff800010049548>] irq_exit+0x1b0/0x1b8 So split the original sugov_tunables_free() into two functions, sugov_clear_global_tunables() is just used to clear the global_tunables and the new sugov_tunables_free() is used as kobj_type::release to release the sugov_tunables safely. Fixes: 9bdcb44e39 ("cpufreq: schedutil: New governor based on scheduler utilization data") Cc: 4.7+ <stable@vger.kernel.org> # 4.7+ Signed-off-by: Kevin Hao <haokexin@gmail.com> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>		2021-08-06 15:34:55 +02:00
..
bpf	bpf: Fix leakage due to insufficient speculative store bypass mitigation	2021-07-29 00:27:52 +02:00
cgroup	cgroup1: fix leaked context root causing sporadic NULL deref in LTP	2021-07-21 06:39:20 -10:00
configs	drivers/char: remove /dev/kmem for good	2021-05-07 00:26:34 -07:00
debug	kernel: debug: Fix unreachable code in gdb_serial_stub()	2021-07-12 11:03:35 -05:00
dma	dma-mapping: handle vmalloc addresses in dma_common_{mmap,get_sgtable}	2021-07-16 11:30:26 +02:00
entry	tick/nohz: Only check for RCU deferred wakeup on user/guest entry when needed	2021-05-31 10:14:49 +02:00
events	Merge branch 'akpm' (patches from Andrew)	2021-06-29 17:29:11 -07:00
gcov	Kconfig: Introduce ARCH_WANTS_NO_INSTR and CC_HAS_NO_PROFILE_FN_ATTR	2021-06-22 11:07:18 -07:00
irq	irqchip fixes for 5.14, take #1	2021-07-09 15:35:13 +02:00
kcsan	Merge branch 'kcsan.2021.05.18a' of git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu	2021-07-04 12:29:16 -07:00
livepatch	Livepatching changes for 5.13	2021-04-27 18:14:38 -07:00
locking	Locking fixes:	2021-07-11 11:06:09 -07:00
power	PM: hibernate: disable when there are active secretmem users	2021-07-08 11:48:21 -07:00
printk	printk changes for 5.14	2021-06-29 12:07:18 -07:00
rcu	rcu: Fix pr_info() formats and values in show_rcu_gp_kthreads()	2021-07-06 15:53:12 -07:00
sched	cpufreq: schedutil: Use kobject release() method to free sugov_tunables	2021-08-06 15:34:55 +02:00
time	timers: Fix get_next_timer_interrupt() with no timers pending	2021-07-15 01:23:54 +02:00
trace	ftrace: Remove redundant initialization of variable ret	2021-07-23 08:46:02 -04:00
.gitignore	.gitignore: prefix local generated files with a slash	2021-05-02 00:43:35 +09:00
acct.c	kernel/acct.c: use #elif instead of #end and #elif	2020-12-15 22:46:15 -08:00
async.c	kernel/async.c: remove async_unregister_domain()	2021-05-07 00:26:33 -07:00
audit_fsnotify.c	audit_alloc_mark(): don't open-code ERR_CAST()	2021-02-23 10:25:27 -05:00
audit_tree.c	audit: Use list_move instead of list_del/list_add	2021-06-08 22:18:35 -04:00
audit_watch.c	fsnotify: generalize handle_inode_event()	2020-12-03 14:58:35 +01:00
audit.c	lsm: separate security_task_getsecid() into subjective and objective variants	2021-03-22 15:23:32 -04:00
audit.h	audit: remove trailing spaces and tabs	2021-06-10 20:59:05 -04:00
auditfilter.c	lsm: separate security_task_getsecid() into subjective and objective variants	2021-03-22 15:23:32 -04:00
auditsc.c	audit: remove trailing spaces and tabs	2021-06-10 20:59:05 -04:00
backtracetest.c
bounds.c
capability.c	capability: handle idmapped mounts	2021-01-24 14:27:16 +01:00
cfi.c	add support for Clang CFI	2021-04-08 16:04:20 -07:00
compat.c
configs.c
context_tracking.c
cpu_pm.c
cpu.c	A fix for the CPU hotplug and cpusets interaction:	2021-06-29 12:23:02 -07:00
crash_core.c	kdump: use vmlinux_build_id to simplify	2021-07-08 11:48:22 -07:00
crash_dump.c
cred.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2021-06-28 20:39:26 -07:00
delayacct.c	delayacct: Add sysctl to enable at runtime	2021-05-12 11:43:25 +02:00
dma.c
exec_domain.c
exit.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2021-06-28 20:39:26 -07:00
extable.c
fail_function.c	fault-injection: handle EI_ETYPE_TRUE	2020-12-15 22:46:19 -08:00
fork.c	Merge branch 'akpm' (patches from Andrew)	2021-06-29 17:29:11 -07:00
freezer.c	sched: Add get_current_state()	2021-06-18 11:43:08 +02:00
futex.c	Locking changes for this cycle:	2021-06-28 11:45:29 -07:00
gen_kheaders.sh	kbuild: clean up ${quiet} checks in shell scripts	2021-05-27 04:01:50 +09:00
groups.c	groups: simplify struct group_info allocation	2021-02-26 09:41:03 -08:00
hung_task.c	Merge branch 'akpm' (patches from Andrew)	2021-07-02 12:08:10 -07:00
iomem.c
irq_work.c	irq_work: Make irq_work_queue() NMI-safe again	2021-06-10 10:00:08 +02:00
jump_label.c	jump_label: Fix jump_label_text_reserved() vs __init	2021-07-05 10:46:20 +02:00
kallsyms.c	module: add printk formats to add module build ID to stacktraces	2021-07-08 11:48:22 -07:00
kcmp.c	Merge branch 'exec-update-lock-for-v5.11' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2020-12-15 19:36:48 -08:00
Kconfig.freezer
Kconfig.hz
Kconfig.locks
Kconfig.preempt	sched/core: Disable CONFIG_SCHED_CORE by default	2021-06-28 22:43:05 +02:00
kcov.c	kernel: make kcov_common_handle consider the current context	2020-11-02 18:00:20 -08:00
kexec_core.c	kernel.h: split out panic and oops helpers	2021-07-01 11:06:04 -07:00
kexec_elf.c
kexec_file.c	kernel: kexec_file: fix error return code of kexec_calculate_store_digests()	2021-05-07 00:26:32 -07:00
kexec_internal.h	kexec: move machine_kexec_post_load() to public interface	2021-02-22 12:33:26 +00:00
kexec.c
kheaders.c
kmod.c	modules: add CONFIG_MODPROBE_PATH	2021-05-07 00:26:33 -07:00
kprobes.c	Locking fixes:	2021-07-11 11:06:09 -07:00
ksysfs.c
kthread.c	Merge branch 'akpm' (patches from Andrew)	2021-06-29 17:29:11 -07:00
latencytop.c
Makefile	kbuild: update config_data.gz only when the content of .config is changed	2021-05-02 00:43:35 +09:00
module_signature.c	module: harden ELF info handling	2021-01-19 10:24:45 +01:00
module_signing.c	module: harden ELF info handling	2021-01-19 10:24:45 +01:00
module-internal.h
module.c	module: add printk formats to add module build ID to stacktraces	2021-07-08 11:48:22 -07:00
notifier.c
nsproxy.c	fixes-v5.11	2020-12-14 16:40:27 -08:00
padata.c
panic.c	kernel.h: split out panic and oops helpers	2021-07-01 11:06:04 -07:00
params.c	Modules updates for v5.11	2020-12-17 13:01:31 -08:00
pid_namespace.c	fixes-v5.11	2020-12-14 16:40:27 -08:00
pid.c	Merge branch 'exec-update-lock-for-v5.11' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2020-12-15 19:36:48 -08:00
profile.c	kernel: Initialize cpumask before parsing	2021-04-10 13:35:54 +02:00
ptrace.c	sched: Change task_struct::state	2021-06-18 11:43:09 +02:00
range.c
reboot.c	reboot: Add hardware protection power-off	2021-06-21 13:08:36 +01:00
regset.c
relay.c	relay: allow the use of const callback structs	2020-12-15 22:46:18 -08:00
resource_kunit.c	resource: provide meaningful MODULE_LICENSE() in test suite	2020-11-25 18:52:35 +01:00
resource.c	kernel/resource: fix return code check in __request_free_mem_region	2021-05-14 19:41:32 -07:00
rseq.c	rseq: Optimise rseq_get_rseq_cs() and clear_rseq_cs()	2021-04-14 18:04:09 +02:00
scftorture.c	scftorture: Avoid false-positive warnings in scftorture_invoker()	2021-07-06 12:37:55 -07:00
scs.c	scs: switch to vmapped shadow stacks	2020-12-01 10:30:28 +00:00
seccomp.c	seccomp: Support atomic "addfd + send reply"	2021-06-28 12:49:52 -07:00
signal.c	Fix UCOUNT_RLIMIT_SIGPENDING counter leak	2021-07-08 11:43:24 -07:00
smp.c	smp: Fix smp_call_function_single_async prototype	2021-05-06 15:33:49 +02:00
smpboot.c	smpboot: fix duplicate and misplaced inlining directive	2021-07-25 11:06:37 -07:00
smpboot.h
softirq.c	sched: Introduce task_is_running()	2021-06-18 11:43:07 +02:00
stackleak.c
stacktrace.c
static_call.c	static_call: Fix static_call_text_reserved() vs __init	2021-07-05 10:46:33 +02:00
stop_machine.c	stop_machine: Add caller debug info to queue_stop_cpus_work	2021-03-23 16:01:58 +01:00
sys_ni.c	mm: introduce memfd_secret system call to create "secret" memory areas	2021-07-08 11:48:21 -07:00
sys.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2021-06-28 20:39:26 -07:00
sysctl-test.c	kernel/sysctl-test: Remove some casts which are no-longer required	2021-06-23 16:41:24 -06:00
sysctl.c	Merge branch 'akpm' (patches from Andrew)	2021-07-02 12:08:10 -07:00
task_work.c	kasan: record task_work_add() call stack	2021-04-30 11:20:42 -07:00
taskstats.c	treewide: rename nla_strlcpy to nla_strscpy.	2020-11-16 08:08:54 -08:00
test_kprobes.c
torture.c	torture: Replace torture_init_begin string with %s	2021-03-08 14:22:28 -08:00
tracepoint.c	tracepoints: Update static_call before tp_funcs when adding a tracepoint	2021-07-23 08:46:22 -04:00
tsacct.c
ucount.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2021-06-28 20:39:26 -07:00
uid16.c
uid16.h
umh.c	kernel/umh.c: fix some spelling mistakes	2021-05-07 00:26:34 -07:00
up.c	A set of locking related fixes and updates:	2021-05-09 13:07:03 -07:00
user_namespace.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2021-06-28 20:39:26 -07:00
user-return-notifier.c
user.c	Reimplement RLIMIT_MEMLOCK on top of ucounts	2021-04-30 14:14:02 -05:00
usermode_driver.c	Merge branch 'work.namei' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2021-07-03 11:41:14 -07:00
utsname_sysctl.c
utsname.c
watch_queue.c	watch_queue: rectify kernel-doc for init_watch()	2021-01-26 11:16:34 +00:00
watchdog_hld.c
watchdog.c	kernel: watchdog: modify the explanation related to watchdog thread	2021-06-29 10:53:46 -07:00
workqueue_internal.h
workqueue.c	workqueue: fix UAF in pwq_unbound_release_workfn()	2021-07-21 06:42:31 -10:00