mirror of
https://git.proxmox.com/git/mirror_ubuntu-kernels.git
synced 2025-11-19 23:45:42 +00:00
strncpy() is deprecated for use on NUL-terminated destination strings [1] and as such we should prefer more robust and less ambiguous string interfaces. To keep node->current_state_name and node->prev_state_name NUL-padded and NUL-terminated let's use strscpy_pad() as this implicitly provides both. For the swap between the two, a simple memcpy() will suffice. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] Link: https://github.com/KSPP/linux/issues/90 Cc: linux-hardening@vger.kernel.org Signed-off-by: Justin Stitt <justinstitt@google.com> Link: https://lore.kernel.org/r/20231026-strncpy-drivers-scsi-elx-libefc-efc_node-h-v2-1-5c083d0c13f4@google.com Reviewed-by: Kees Cook <keescook@chromium.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
||
|---|---|---|
| .. | ||
| efc_cmds.c | ||
| efc_cmds.h | ||
| efc_device.c | ||
| efc_device.h | ||
| efc_domain.c | ||
| efc_domain.h | ||
| efc_els.c | ||
| efc_els.h | ||
| efc_fabric.c | ||
| efc_fabric.h | ||
| efc_node.c | ||
| efc_node.h | ||
| efc_nport.c | ||
| efc_nport.h | ||
| efc_sm.c | ||
| efc_sm.h | ||
| efc.h | ||
| efclib.c | ||
| efclib.h | ||