mirror_ubuntu-kernels/drivers/gpu/drm/msm
Miguel Ojeda d3bbc4dfcc drm/msm: fix the CRASHDUMP_READ target of a6xx_get_shader_block()
Clang 14 in an (essentially) defconfig arm64 build for next-20240326
reports [1]:

    drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error:
    variable 'out' set but not used [-Werror,-Wunused-but-set-variable]

The variable `out` in these functions is meant to compute the `target` of
`CRASHDUMP_READ()`, but in this case only the initial value (`dumper->iova
+ A6XX_CD_DATA_OFFSET`) was being passed.

Thus use `out` as it was intended by Connor [2].

There was an alternative patch at [3] that removed the variable
altogether, but that would only use the initial value.

Fixes: 64d6255650 ("drm/msm: More fully implement devcoredump for a7xx")
Closes: https://lore.kernel.org/lkml/CANiq72mjc5t4n25SQvYSrOEhxxpXYPZ4pPzneSJHEnc3qApu2Q@mail.gmail.com/ [1]
Link: https://lore.kernel.org/lkml/CACu1E7HhCKMJd6fixZSPiNAz6ekoZnkMTHTcLFVmbZ-9VoLxKg@mail.gmail.com/ [2]
Link: https://lore.kernel.org/lkml/20240307093727.1978126-1-colin.i.king@gmail.com/ [3]
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/584955/
Signed-off-by: Rob Clark <robdclark@chromium.org>
2024-04-05 11:21:26 -07:00
..
adreno drm/msm: fix the CRASHDUMP_READ target of a6xx_get_shader_block() 2024-04-05 11:21:26 -07:00
disp drm/msm/dpu: make error messages at dpu_core_irq_register_callback() more sensible 2024-04-01 16:02:40 -07:00
dp drm/msm/dp: fix typo in dp_display_handle_port_status_changed() 2024-04-01 19:28:20 -07:00
dsi drm/msm/dsi: Document DSC related pclk_rate and hdisplay calculations 2024-02-11 22:38:08 +02:00
hdmi drm/msm/hdmi: switch to ->edid_read callback 2024-02-09 10:15:57 +02:00
Kconfig drm/msm/gem: Convert to drm_exec 2023-12-10 11:19:44 -08:00
Makefile drm/msm/dp: move parity calculation to dp_utils 2024-03-04 11:35:05 +02:00
msm_atomic_trace.h
msm_atomic_tracepoints.c
msm_atomic.c
msm_debugfs.c drm/msm: don't create GPU-related debugfs files with no GPU present 2023-11-20 18:31:42 -08:00
msm_debugfs.h
msm_drv.c drm/msm/dpu: add support for SDM660 and SDM630 platforms 2024-02-19 13:39:40 +02:00
msm_drv.h drm/msm/dpu: split dpu_encoder_wait_for_event into two functions 2024-03-04 11:41:09 +02:00
msm_dsc_helper.h
msm_fb.c drm/msm: Add newlines to some debug prints 2024-03-29 13:25:22 -07:00
msm_fbdev.c fbdev: Align deferred I/O with naming of helpers 2023-07-31 20:07:24 +02:00
msm_fence.c
msm_fence.h
msm_gem_prime.c drm/msm/gem: Fix double resv lock aquire 2024-02-01 14:59:35 -08:00
msm_gem_shrinker.c drm/msm: Reduce fallout of fence signaling vs reclaim hangs 2023-11-20 17:15:02 -08:00
msm_gem_submit.c drm/msm/gem: Convert to drm_exec 2023-12-10 11:19:44 -08:00
msm_gem_vma.c drm/msm: Remove vma use tracking 2023-08-10 13:08:03 -07:00
msm_gem.c drm/msm/gem: Demote userspace errors to DRM_UT_DRIVER 2023-11-20 18:35:26 -08:00
msm_gem.h drm/msm/gem: Convert to drm_exec 2023-12-10 11:19:44 -08:00
msm_gpu_devfreq.c
msm_gpu_trace.h
msm_gpu_tracepoints.c
msm_gpu.c Revert "drm/msm/gpu: Push gpu lock down past runpm" 2024-02-01 15:24:10 -08:00
msm_gpu.h drm/sched: Reverse run-queue priority enumeration 2023-11-24 23:03:53 -05:00
msm_gpummu.c
msm_io_utils.c drm/msm/dpu: support binding to the mdp5 devices 2024-02-19 13:39:39 +02:00
msm_iommu.c drm/msm: Wire up tlb ops 2024-02-15 08:51:31 -08:00
msm_kms.c drm/msm: Add newlines to some debug prints 2024-03-29 13:25:22 -07:00
msm_kms.h drm/msm/mdp5: drop split display support 2024-02-11 22:38:06 +02:00
msm_mdss.c drm/msm: mdss: Add X1E80100 support 2024-02-22 23:23:24 +02:00
msm_mdss.h drm/msm/mdss: Handle the reg bus ICC path 2023-12-05 04:09:43 +03:00
msm_mmu.h
msm_perf.c
msm_rd.c drm/msm: don't create GPU-related debugfs files with no GPU present 2023-11-20 18:31:42 -08:00
msm_ringbuffer.c Revert "drm/msm/gpu: Push gpu lock down past runpm" 2024-02-01 15:24:10 -08:00
msm_ringbuffer.h drm/msm/a6xx: Add skeleton A7xx support 2023-10-09 11:22:05 -07:00
msm_submitqueue.c
NOTES