mirror_ubuntu-kernels/drivers/net/ethernet/broadcom/genet
Doug Berger 0686bd9d5e net: bcmgenet: reapply manual settings to the PHY
The phy_init_hw() function may reset the PHY to a configuration
that does not match manual network settings stored in the phydev
structure. If the phy state machine is polled rather than event
driven this can create a timing hazard where the phy state machine
might alter the settings stored in the phydev structure from the
value read from the BMCR.

This commit follows invocations of phy_init_hw() by the bcmgenet
driver with invocations of the genphy_config_aneg() function to
ensure that the BMCR is written to match the settings held in the
phydev structure. This prevents the risk of manual settings being
accidentally altered.

Fixes: 1c1008c793 ("net: bcmgenet: add main driver file")
Signed-off-by: Doug Berger <opendmb@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-11-06 10:46:22 -08:00
..
bcmgenet_wol.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
bcmgenet.c net: bcmgenet: reapply manual settings to the PHY 2019-11-06 10:46:22 -08:00
bcmgenet.h Revert "net: bcmgenet: soft reset 40nm EPHYs before MAC init" 2019-11-06 10:46:22 -08:00
bcmmii.c Revert "net: bcmgenet: soft reset 40nm EPHYs before MAC init" 2019-11-06 10:46:22 -08:00
Makefile treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00