mirror_ubuntu-kernels/drivers/platform/x86/intel/int3472
Hans de Goede cf5ac2d45f platform/x86: int3472/discrete: Ensure the clk/power enable pins are in output mode
acpi_get_and_request_gpiod() does not take a gpio_lookup_flags argument
specifying that the pins direction should be initialized to a specific
value.

This means that in some cases the pins might be left in input mode, causing
the gpiod_set() calls made to enable the clk / regulator to not work.

One example of this problem is the clk-enable GPIO for the ov01a1s sensor
on a Dell Latitude 9420 being left in input mode causing the clk to
never get enabled.

Explicitly set the direction of the pins to output to fix this.

Fixes: 5de691bffe ("platform/x86: Add intel_skl_int3472 driver")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Reviewed-by: Daniel Scally <djrscally@gmail.com>
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Link: https://lore.kernel.org/r/20230111201426.947853-1-hdegoede@redhat.com
2023-01-12 20:10:31 +01:00
..
clk_and_regulator.c platform/x86: int3472/discrete: Ensure the clk/power enable pins are in output mode 2023-01-12 20:10:31 +01:00
common.c ACPI: scan: Add acpi_dev_get_next_consumer_dev() 2022-09-24 19:12:32 +02:00
common.h platform/x86: int3472: Add get_sensor_adev_and_name() helper 2021-12-13 11:44:48 +01:00
discrete.c platform/x86: int3472/discrete: Ensure the clk/power enable pins are in output mode 2023-01-12 20:10:31 +01:00
Kconfig
Makefile platform/x86: int3472: Pass tps68470_regulator_platform_data to the tps68470-regulator MFD-cell 2021-12-13 11:44:50 +01:00
tps68470_board_data.c platform/x86: int3472: Add board data for Surface Go2 IR camera 2022-09-24 19:12:32 +02:00
tps68470.c More ACPI updates for 6.1-rc1 2022-10-10 13:28:06 -07:00
tps68470.h platform/x86: int3472: Support multiple gpio lookups in board data 2022-09-24 19:12:32 +02:00