mirror of
https://git.proxmox.com/git/mirror_ubuntu-kernels.git
synced 2026-01-05 21:31:40 +00:00
cf4674c46c
Setting si_code to 0 results in a userspace seeing an si_code of 0. This is the same si_code as SI_USER. Posix and common sense requires that SI_USER not be a signal specific si_code. As such this use of 0 for the si_code is a pretty horribly broken ABI. Further use of si_code == 0 guaranteed that copy_siginfo_to_user saw a value of __SI_KILL and now sees a value of SIL_KILL with the result that uid and pid fields are copied and which might copying the si_addr field by accident but certainly not by design. Making this a very flakey implementation. Utilizing FPE_FIXME and TRAP_FIXME, siginfo_layout() will now return SIL_FAULT and the appropriate fields will be reliably copied. Possible ABI fixes includee: - Send the signal without siginfo - Don't generate a signal - Possibly assign and use an appropriate si_code - Don't handle cases which can't happen Cc: Paul Mackerras <paulus@samba.org> Cc: Kumar Gala <kumar.gala@freescale.com> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: linuxppc-dev@lists.ozlabs.org Ref: 9bad068c24d7 ("[PATCH] ppc32: support for e500 and 85xx") Ref: 0ed70f6105ef ("PPC32: Provide proper siginfo information on various exceptions.") History Tree: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
37 lines
813 B
C
37 lines
813 B
C
/* SPDX-License-Identifier: GPL-2.0+ WITH Linux-syscall-note */
|
|
#ifndef _ASM_POWERPC_SIGINFO_H
|
|
#define _ASM_POWERPC_SIGINFO_H
|
|
|
|
/*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version
|
|
* 2 of the License, or (at your option) any later version.
|
|
*/
|
|
|
|
#ifdef __powerpc64__
|
|
# define __ARCH_SI_PREAMBLE_SIZE (4 * sizeof(int))
|
|
#endif
|
|
|
|
#include <asm-generic/siginfo.h>
|
|
|
|
#undef NSIGTRAP
|
|
#define NSIGTRAP 4
|
|
|
|
/*
|
|
* SIGFPE si_codes
|
|
*/
|
|
#ifdef __KERNEL__
|
|
#define FPE_FIXME 0 /* Broken dup of SI_USER */
|
|
#endif /* __KERNEL__ */
|
|
|
|
/*
|
|
* SIGTRAP si_codes
|
|
*/
|
|
#ifdef __KERNEL__
|
|
#define TRAP_FIXME 0 /* Broken dup of SI_USER */
|
|
#endif /* __KERNEL__ */
|
|
|
|
|
|
#endif /* _ASM_POWERPC_SIGINFO_H */
|