mirror of
https://git.proxmox.com/git/mirror_ubuntu-kernels.git
synced 2025-11-18 17:12:07 +00:00
df10317085
When building with -Wsometimes-uninitialized, Clang warns: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:495:3: warning: variable 'ns' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:495:3: warning: variable 'ns' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized] drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:532:3: warning: variable 'ns' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:532:3: warning: variable 'ns' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized] drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:741:3: warning: variable 'sec_inc' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:741:3: warning: variable 'sec_inc' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized] Clang is concerned with the use of stmmac_do_void_callback (which stmmac_get_timestamp and stmmac_config_sub_second_increment wrap), as it may fail to initialize these values if the if condition was ever false (meaning the callbacks don't exist). It's not wrong because the callbacks (get_timestamp and config_sub_second_increment respectively) are the ones that initialize the variables. While it's unlikely that the callbacks are ever going to disappear and make that condition false, we can easily avoid this warning by zero initialize the variables. Link: https://github.com/ClangBuiltLinux/linux/issues/384 Suggested-by: Nick Desaulniers <ndesaulniers@google.com> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> |
||
|---|---|---|
| .. | ||
| altr_tse_pcs.c | ||
| altr_tse_pcs.h | ||
| chain_mode.c | ||
| common.h | ||
| descs_com.h | ||
| descs.h | ||
| dwmac4_core.c | ||
| dwmac4_descs.c | ||
| dwmac4_descs.h | ||
| dwmac4_dma.c | ||
| dwmac4_dma.h | ||
| dwmac4_lib.c | ||
| dwmac4.h | ||
| dwmac5.c | ||
| dwmac5.h | ||
| dwmac100_core.c | ||
| dwmac100_dma.c | ||
| dwmac100.h | ||
| dwmac1000_core.c | ||
| dwmac1000_dma.c | ||
| dwmac1000.h | ||
| dwmac_dma.h | ||
| dwmac_lib.c | ||
| dwmac-anarion.c | ||
| dwmac-dwc-qos-eth.c | ||
| dwmac-generic.c | ||
| dwmac-ipq806x.c | ||
| dwmac-lpc18xx.c | ||
| dwmac-mediatek.c | ||
| dwmac-meson8b.c | ||
| dwmac-meson.c | ||
| dwmac-oxnas.c | ||
| dwmac-qcom-ethqos.c | ||
| dwmac-rk.c | ||
| dwmac-socfpga.c | ||
| dwmac-sti.c | ||
| dwmac-stm32.c | ||
| dwmac-sun8i.c | ||
| dwmac-sunxi.c | ||
| dwxgmac2_core.c | ||
| dwxgmac2_descs.c | ||
| dwxgmac2_dma.c | ||
| dwxgmac2.h | ||
| enh_desc.c | ||
| hwif.c | ||
| hwif.h | ||
| Kconfig | ||
| Makefile | ||
| mmc_core.c | ||
| mmc.h | ||
| norm_desc.c | ||
| ring_mode.c | ||
| stmmac_ethtool.c | ||
| stmmac_hwtstamp.c | ||
| stmmac_main.c | ||
| stmmac_mdio.c | ||
| stmmac_pci.c | ||
| stmmac_pcs.h | ||
| stmmac_platform.c | ||
| stmmac_platform.h | ||
| stmmac_ptp.c | ||
| stmmac_ptp.h | ||
| stmmac_tc.c | ||
| stmmac.h | ||