NeilBrown 45bb63ed20 nfsd: fix delegation_blocked() to block correctly for at least 30 seconds ... The pair of bloom filtered used by delegation_blocked() was intended to block delegations on given filehandles for between 30 and 60 seconds. A new filehandle would be recorded in the "new" bit set. That would then be switch to the "old" bit set between 0 and 30 seconds later, and it would remain as the "old" bit set for 30 seconds. Unfortunately the code intended to clear the old bit set once it reached 30 seconds old, preparing it to be the next new bit set, instead cleared the *new* bit set before switching it to be the old bit set. This means that the "old" bit set is always empty and delegations are blocked between 0 and 30 seconds. This patch updates bd->new before clearing the set with that index, instead of afterwards. Reported-by: Olga Kornievskaia <okorniev@redhat.com> Cc: stable@vger.kernel.org Fixes: 6282cd5655 ("NFSD: Don't hand out delegations for 30 seconds after recalling them.") Signed-off-by: NeilBrown <neilb@suse.de> Reviewed-by: Benjamin Coddington <bcodding@redhat.com> Reviewed-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>		2024-09-20 19:31:38 -04:00
..
acl.h	NFSD: add posix ACLs to struct nfsd_attrs	2022-08-04 10:28:03 -04:00
auth.c	nfsd: Pass 'cred' instead of 'rqstp' to some functions.	2024-09-20 19:31:03 -04:00
auth.h	nfsd: Pass 'cred' instead of 'rqstp' to some functions.	2024-09-20 19:31:03 -04:00
blocklayout.c	NFSD: Annotate struct pnfs_block_deviceaddr with __counted_by()	2024-09-20 19:31:03 -04:00
blocklayoutxdr.c	NFSD: Make @gdev parameter of ->encode_getdeviceinfo a const pointer	2023-10-16 12:44:29 -04:00
blocklayoutxdr.h	NFSD: Annotate struct pnfs_block_deviceaddr with __counted_by()	2024-09-20 19:31:03 -04:00
cache.h	nfsd: don't allocate the versions array.	2024-09-20 19:29:23 -04:00
current_stateid.h
export.c	nfsd: Move error code mapping to per-version proc code.	2024-09-20 19:31:03 -04:00
export.h	nfsd: Pass 'cred' instead of 'rqstp' to some functions.	2024-09-20 19:31:03 -04:00
filecache.c	nfsd: remove unused parameter of nfsd_file_mark_find_or_create	2024-09-20 19:31:03 -04:00
filecache.h	nfsd: add list_head nf_gc to struct nfsd_file	2024-09-01 10:04:53 -04:00
flexfilelayout.c	nfsd: move nfserrno() to vfs.c	2022-11-28 12:54:44 -05:00
flexfilelayoutxdr.c	NFSD: Make @gdev parameter of ->encode_getdeviceinfo a const pointer	2023-10-16 12:44:29 -04:00
flexfilelayoutxdr.h	NFSD: Make @gdev parameter of ->encode_getdeviceinfo a const pointer	2023-10-16 12:44:29 -04:00
idmap.h
Kconfig	NFSD: Fix nfsdcld warning	2024-07-08 14:10:02 -04:00
lockd.c	NFSD: simplify struct nfsfh	2021-10-02 15:51:10 -04:00
Makefile	NFSD: introduce netlink stubs	2023-10-16 12:44:09 -04:00
netlink.c	nfsd: new netlink ops to get/set server pool_mode	2024-07-08 14:10:05 -04:00
netlink.h	nfsd: new netlink ops to get/set server pool_mode	2024-07-08 14:10:05 -04:00
netns.h	NFSD: Limit the number of concurrent async COPY operations	2024-09-20 19:31:03 -04:00
nfs2acl.c	NFSD: remove unused structs 'nfsd3_voidargs'	2024-07-08 14:10:01 -04:00
nfs3acl.c	NFSD: remove unused structs 'nfsd3_voidargs'	2024-07-08 14:10:01 -04:00
nfs3proc.c	nfsd: move error choice for incorrect object types to version-specific code.	2024-09-20 19:31:03 -04:00
nfs3xdr.c	nfsd: Fix NFSv3 atomicity bugs in nfsd_setattr()	2024-03-01 09:12:33 -05:00
nfs4acl.c	nfsd: inherit required unset default acls from effective set	2023-08-29 17:45:22 -04:00
nfs4callback.c	nfsd: add more nfsd_cb tracepoints	2024-09-20 19:31:03 -04:00
nfs4idmap.c	nfsd: call cache_put if xdr_reserve_space returns NULL	2024-09-20 19:31:03 -04:00
nfs4layouts.c	nfsd: track the main opcode for callbacks	2024-09-20 19:31:03 -04:00
nfs4proc.c	NFSD: Wrap async copy operations with trace points	2024-09-20 19:31:03 -04:00
nfs4recover.c	nfsd: enforce upper limit for namelen in __cld_pipe_inprogress_downcall()	2024-09-20 19:31:35 -04:00
nfs4state.c	nfsd: fix delegation_blocked() to block correctly for at least 30 seconds	2024-09-20 19:31:38 -04:00
nfs4xdr.c	NFSD: Fix NFSv4's PUTPUBFH operation	2024-09-20 19:31:03 -04:00
nfscache.c	nfsd: Simplify the allocation of slab caches in nfsd_drc_slab_create	2024-03-01 09:12:24 -05:00
nfsctl.c	sunrpc: change sp_nrthreads from atomic_t to unsigned int.	2024-09-20 19:31:03 -04:00
nfsd.h	nfsd: move error choice for incorrect object types to version-specific code.	2024-09-20 19:31:03 -04:00
nfsfh.c	nfsd: move error choice for incorrect object types to version-specific code.	2024-09-20 19:31:03 -04:00
nfsfh.h	nfsd: further centralize protocol version checks.	2024-09-20 19:31:03 -04:00
nfsproc.c	nfsd: move error choice for incorrect object types to version-specific code.	2024-09-20 19:31:03 -04:00
nfssvc.c	nfsd: use nfsd_v4client() in nfsd_breaker_owns_lease()	2024-09-20 19:31:03 -04:00
nfsxdr.c	NFSD: Ensure that xdr_write_pages updates rq_next_page	2023-06-05 09:01:44 -04:00
pnfs.h	nfsd: allow layout state to be admin-revoked.	2024-03-01 09:12:22 -05:00
state.h	nfsd: track the main opcode for callbacks	2024-09-20 19:31:03 -04:00
stats.c	fs: nfsd: use group allocation/free of per-cpu counters API	2024-05-06 09:07:17 -04:00
stats.h	fs: nfsd: use group allocation/free of per-cpu counters API	2024-05-06 09:07:17 -04:00
trace.c
trace.h	NFSD: Wrap async copy operations with trace points	2024-09-20 19:31:03 -04:00
vfs.c	nfsd: map the EBADMSG to nfserr_io to avoid warning	2024-09-20 19:31:03 -04:00
vfs.h	nfsd: Pass 'cred' instead of 'rqstp' to some functions.	2024-09-20 19:31:03 -04:00
xdr3.h	nfsd: Fix NFSv3 atomicity bugs in nfsd_setattr()	2024-03-01 09:12:33 -05:00
xdr4.h	NFSD: Limit the number of concurrent async COPY operations	2024-09-20 19:31:03 -04:00
xdr4cb.h	NFSD: add support for CB_GETATTR callback	2024-03-01 09:12:31 -05:00
xdr.h	NFSD: prevent underflow in nfssvc_decode_writeargs()	2022-03-15 09:35:56 -04:00