mirror_ubuntu-kernels

mirror of https://git.proxmox.com/git/mirror_ubuntu-kernels.git synced 2025-12-25 10:21:43 +00:00

Go to file

Zhihao Cheng afd4270480 ubifs: Fix deadlock in concurrent rename whiteout and inode writeback Following hung tasks: [ 77.028764] task:kworker/u8:4 state:D stack: 0 pid: 132 [ 77.028820] Call Trace: [ 77.029027] schedule+0x8c/0x1b0 [ 77.029067] mutex_lock+0x50/0x60 [ 77.029074] ubifs_write_inode+0x68/0x1f0 [ubifs] [ 77.029117] __writeback_single_inode+0x43c/0x570 [ 77.029128] writeback_sb_inodes+0x259/0x740 [ 77.029148] wb_writeback+0x107/0x4d0 [ 77.029163] wb_workfn+0x162/0x7b0 [ 92.390442] task:aa state:D stack: 0 pid: 1506 [ 92.390448] Call Trace: [ 92.390458] schedule+0x8c/0x1b0 [ 92.390461] wb_wait_for_completion+0x82/0xd0 [ 92.390469] __writeback_inodes_sb_nr+0xb2/0x110 [ 92.390472] writeback_inodes_sb_nr+0x14/0x20 [ 92.390476] ubifs_budget_space+0x705/0xdd0 [ubifs] [ 92.390503] do_rename.cold+0x7f/0x187 [ubifs] [ 92.390549] ubifs_rename+0x8b/0x180 [ubifs] [ 92.390571] vfs_rename+0xdb2/0x1170 [ 92.390580] do_renameat2+0x554/0x770 , are caused by concurrent rename whiteout and inode writeback processes: rename_whiteout(Thread 1) wb_workfn(Thread2) ubifs_rename do_rename lock_4_inodes (Hold ui_mutex) ubifs_budget_space make_free_space shrink_liability __writeback_inodes_sb_nr bdi_split_work_to_wbs (Queue new wb work) wb_do_writeback(wb work) __writeback_single_inode ubifs_write_inode LOCK(ui_mutex) ↑ wb_wait_for_completion (Wait wb work) <-- deadlock! Reproducer (Detail program in [Link]): 1. SYS_renameat2("/mp/dir/file", "/mp/dir/whiteout", RENAME_WHITEOUT) 2. Consume out of space before kernel(mdelay) doing budget for whiteout Fix it by doing whiteout space budget before locking ubifs inodes. BTW, it also fixes wrong goto tag 'out_release' in whiteout budget error handling path(It should at least recover dir i_size and unlock 4 ubifs inodes). Fixes: `9e0a1fff8d` ("ubifs: Implement RENAME_WHITEOUT") Link: https://bugzilla.kernel.org/show_bug.cgi?id=214733 Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com> Signed-off-by: Richard Weinberger <richard@nod.at>		2022-01-09 21:33:25 +01:00
arch	Two small fixes, one of which was being worked around in selftests.	2021-12-19 12:44:03 -08:00
block	block-5.16-2021-12-19	2021-12-19 12:38:53 -08:00
certs	certs: Add support for using elliptic curve keys for signing modules	2021-08-23 19:55:42 +03:00
crypto	Update to zstd-1.4.10	2021-11-13 15:32:30 -08:00
Documentation	ubifs: Document sysfs nodes	2021-12-23 20:23:42 +01:00
drivers	ubi: Fix race condition between ctrl_cdev_ioctl and ubi_cdev_ioctl	2022-01-09 21:13:28 +01:00
fs	ubifs: Fix deadlock in concurrent rename whiteout and inode writeback	2022-01-09 21:33:25 +01:00
include	Networking fixes for 5.16-rc6, including fixes from mac80211, wifi, bpf.	2021-12-16 15:02:14 -08:00
init	kbuild: Fix -Wimplicit-fallthrough=5 error for GCC 5.x and 6.x	2021-11-14 18:59:49 -08:00
ipc	shm: extend forced shm destroy to support objects from several IPC nses	2021-11-20 10:35:54 -08:00
kernel	- Make sure the CLOCK_REALTIME to CLOCK_MONOTONIC offset is never positive	2021-12-19 12:23:18 -08:00
lib	Merge https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf	2021-12-08 16:06:44 -08:00
LICENSES	LICENSES/dual/CC-BY-4.0: Git rid of "smart quotes"	2021-07-15 06:31:24 -06:00
mm	Merge branch 'for-5.16-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/dennis/percpu	2021-12-11 16:14:17 -08:00
net	Networking fixes for 5.16-rc6, including fixes from mac80211, wifi, bpf.	2021-12-16 15:02:14 -08:00
samples	ftrace/samples: Add module to test multi direct modify interface	2021-12-09 13:02:44 -05:00
scripts	recordmcount.pl: look for jgnop instruction as well as bcrl on s390	2021-12-12 18:52:26 +01:00
security	selinux: fix sleeping function called from invalid context	2021-12-16 17:47:39 -05:00
sound	sound fixes for 5.16-rc5	2021-12-10 11:43:00 -08:00
tools	Two small fixes, one of which was being worked around in selftests.	2021-12-19 12:44:03 -08:00
usr	initramfs: Check timestamp to prevent broken cpio archive	2021-10-24 13:48:40 +09:00
virt	KVM: downgrade two BUG_ONs to WARN_ON_ONCE	2021-11-26 06:43:28 -05:00
.clang-format	clang-format: Update with the latest for_each macro list	2021-05-12 23:32:39 +02:00
.cocciconfig
.get_maintainer.ignore	Opt out of scripts/get_maintainer.pl	2019-05-16 10:53:40 -07:00
.gitattributes	.gitattributes: use 'dts' diff driver for dts files	2019-12-04 19:44:11 -08:00
.gitignore	.gitignore: ignore only top-level modules.builtin	2021-05-02 00:43:35 +09:00
.mailmap	mailmap: update email address for Guo Ren	2021-12-10 17:10:55 -08:00
COPYING	COPYING: state that all contributions really are covered by this file	2020-02-10 13:32:20 -08:00
CREDITS	MAINTAINERS: Move Daniel Drake to credits	2021-09-21 08:34:58 +03:00
Kbuild	kbuild: rename hostprogs-y/always to hostprogs/always-y	2020-02-04 01:53:07 +09:00
Kconfig	kbuild: ensure full rebuild when the compiler is updated	2020-05-12 13:28:33 +09:00
MAINTAINERS	ubifs: Document sysfs nodes	2021-12-23 20:23:42 +01:00
Makefile	Linux 5.16-rc6	2021-12-19 14:14:33 -08:00
README	Drop all 00-INDEX files from Documentation/	2018-09-09 15:08:58 -06:00

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.