mirror of
https://git.proxmox.com/git/mirror_ubuntu-kernels.git
synced 2025-12-12 06:43:23 +00:00
1a6dd99966
clang emits a -Wunaligned-access warning on union
mcp251xfd_tx_ojb_load_buf.
The reason is that field hw_tx_obj (not declared as packed) is being
packed right after a 16 bits field inside a packed struct:
| union mcp251xfd_tx_obj_load_buf {
| struct __packed {
| struct mcp251xfd_buf_cmd cmd;
| /* ^ 16 bits fields */
| struct mcp251xfd_hw_tx_obj_raw hw_tx_obj;
| /* ^ not declared as packed */
| } nocrc;
| struct __packed {
| struct mcp251xfd_buf_cmd_crc cmd;
| struct mcp251xfd_hw_tx_obj_raw hw_tx_obj;
| __be16 crc;
| } crc;
| } ____cacheline_aligned;
Starting from LLVM 14, having an unpacked struct nested in a packed
struct triggers a warning. c.f. [1].
This is a false positive because the field is always being accessed
with the relevant put_unaligned_*() function. Adding __packed to the
structure declaration silences the warning.
[1] https://github.com/llvm/llvm-project/issues/55520
Link: https://lore.kernel.org/all/20220518114357.55452-1-mailhol.vincent@wanadoo.fr
Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Reported-by: kernel test robot <lkp@intel.com>
Tested-by: Nathan Chancellor <nathan@kernel.org> # build
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
|
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| mcp251xfd-chip-fifo.c | ||
| mcp251xfd-core.c | ||
| mcp251xfd-crc16.c | ||
| mcp251xfd-dump.c | ||
| mcp251xfd-dump.h | ||
| mcp251xfd-ethtool.c | ||
| mcp251xfd-ram.c | ||
| mcp251xfd-ram.h | ||
| mcp251xfd-regmap.c | ||
| mcp251xfd-ring.c | ||
| mcp251xfd-rx.c | ||
| mcp251xfd-tef.c | ||
| mcp251xfd-timestamp.c | ||
| mcp251xfd-tx.c | ||
| mcp251xfd.h | ||