Suren Baghdasaryan a06247c680 psi: Fix uaf issue when psi trigger is destroyed while being polled ... With write operation on psi files replacing old trigger with a new one, the lifetime of its waitqueue is totally arbitrary. Overwriting an existing trigger causes its waitqueue to be freed and pending poll() will stumble on trigger->event_wait which was destroyed. Fix this by disallowing to redefine an existing psi trigger. If a write operation is used on a file descriptor with an already existing psi trigger, the operation will fail with EBUSY error. Also bypass a check for psi_disabled in the psi_trigger_destroy as the flag can be flipped after the trigger is created, leading to a memory leak. Fixes: 0e94682b73 ("psi: introduce psi monitor") Reported-by: syzbot+cdb5dd11c97cc532efad@syzkaller.appspotmail.com Suggested-by: Linus Torvalds <torvalds@linux-foundation.org> Analyzed-by: Eric Biggers <ebiggers@kernel.org> Signed-off-by: Suren Baghdasaryan <surenb@google.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Eric Biggers <ebiggers@google.com> Acked-by: Johannes Weiner <hannes@cmpxchg.org> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20220111232309.1786347-1-surenb@google.com		2022-01-18 12:09:57 +01:00
..
cgroup-internal.h	cgroup: Use open-time cgroup namespace for process migration perm checks	2022-01-06 11:02:29 -10:00
cgroup-v1.c	cgroup: Allocate cgroup_file_ctx for kernfs_open_file->priv	2022-01-06 11:02:29 -10:00
cgroup.c	psi: Fix uaf issue when psi trigger is destroyed while being polled	2022-01-18 12:09:57 +01:00
cpuset.c	cpuset: convert 'allowed' in __cpuset_node_allowed() to be boolean	2022-01-07 12:05:52 -10:00
debug.c	kernel: cgroup: fix misuse of %x	2019-05-06 08:47:48 -07:00
freezer.c	cgroup: freezer: don't change task and cgroups status unnecessarily	2019-11-07 07:38:41 -08:00
legacy_freezer.c	cgroup: rename freezer.c into legacy_freezer.c	2019-04-19 11:26:48 -07:00
Makefile	cgroup: Add misc cgroup controller	2021-04-04 13:34:46 -04:00
misc.c	misc_cgroup: remove error log to avoid log flood	2021-09-20 07:35:38 -10:00
namespace.c	memcg: enable accounting for new namesapces and struct nsproxy	2021-09-03 09:58:12 -07:00
pids.c	clone3: allow spawning processes into cgroups	2020-02-12 17:57:51 -05:00
rdma.c	cgroup: fix spelling mistakes	2021-05-24 12:45:26 -04:00
rstat.c	cgroup/rstat: check updated_next only for root	2022-01-06 11:50:34 -10:00