Florian Westphal a82c25c366 Revert "netfilter: nat: force port remap to prevent shadowing well-known ports" ... This reverts commit 878aed8db3. This change breaks existing setups where conntrack is used with asymmetric paths. In these cases, the NAT transformation occurs on the syn-ack instead of the syn: 1. SYN x:12345 -> y -> 443 // sent by initiator, receiverd by responder 2. SYNACK y:443 -> x:12345 // First packet seen by conntrack, as sent by responder 3. tuple_force_port_remap() gets called, sees: 'tcp from 443 to port 12345 NAT' -> pick a new source port, inititor receives 4. SYNACK y:$RANDOM -> x:12345 // connection is never established While its possible to avoid the breakage with NOTRACK rules, a kernel update should not break working setups. An alternative to the revert is to augment conntrack to tag mid-stream connections plus more code in the nat core to skip NAT for such connections, however, this leads to more interaction/integration between conntrack and NAT. Therefore, revert, users will need to add explicit nat rules to avoid port shadowing. Link: https://lore.kernel.org/netfilter-devel/20220302105908.GA5852@breakpoint.cc/#R Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2051413 Signed-off-by: Florian Westphal <fw@strlen.de>		2022-03-08 13:52:11 +01:00
..
cxl	cxl/test: Mock acpi_table_parse_cedt()	2021-11-15 11:03:00 -08:00
fault-injection
ktest	bootconfig/tracing/ktest: Update ktest example for boot-time tracing	2021-08-16 11:39:51 -04:00
kunit	kunit: fix missing f in f-string in run_checks.py	2022-02-02 11:12:15 -07:00
nvdimm	memremap: remove support for external pgmap refcounts	2021-12-04 12:46:09 -08:00
radix-tree	tools: Fix math.h breakage	2021-11-30 09:14:42 -08:00
scatterlist	tools/testing/scatterlist: add missing defines	2022-01-30 09:56:58 +02:00
selftests	Revert "netfilter: nat: force port remap to prevent shadowing well-known ports"	2022-03-08 13:52:11 +01:00
vsock	vsock_diag_test: remove free_sock_stat() call in test_no_sockets	2021-10-15 17:21:34 -07:00