mirror of
https://git.proxmox.com/git/mirror_ubuntu-kernels.git
synced 2025-11-16 09:04:13 +00:00
94545f2715
Move the implementation of fb_pgprotect() to fbdev.c and include
<asm/fb.h>. Fixes the following warning:
../arch/x86/video/fbdev.c:14:5: warning: no previous prototype for 'fb_is_primary_device' [-Wmissing-prototypes]
14 | int fb_is_primary_device(struct fb_info *info)
| ^~~~~~~~~~~~~~~~~~~~
Just including <asm/fb.h> results in a number of built-in errors
about undefined function. Moving fb_pgprotect() to the source file
avoids the required include statements in the header. The function
is only called occasionally from fb_mmap(), [1] so having it as static
inline had no benefit.
While at it, fix the codying style in fbdev.c.
Link: https://elixir.bootlin.com/linux/v6.3-rc7/source/drivers/video/fbdev/core/fbmem.c#L1404 # 1
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230424084751.14641-1-tzimmermann@suse.de
18 lines
412 B
C
18 lines
412 B
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef _ASM_X86_FB_H
|
|
#define _ASM_X86_FB_H
|
|
|
|
struct fb_info;
|
|
struct file;
|
|
struct vm_area_struct;
|
|
|
|
void fb_pgprotect(struct file *file, struct vm_area_struct *vma, unsigned long off);
|
|
#define fb_pgprotect fb_pgprotect
|
|
|
|
int fb_is_primary_device(struct fb_info *info);
|
|
#define fb_is_primary_device fb_is_primary_device
|
|
|
|
#include <asm-generic/fb.h>
|
|
|
|
#endif /* _ASM_X86_FB_H */
|