mirror of
https://git.proxmox.com/git/mirror_ubuntu-kernels.git
synced 2025-11-20 06:29:44 +00:00
292a089d78
Due to several bugs caused by timers being re-armed after they are
shutdown and just before they are freed, a new state of timers was added
called "shutdown". After a timer is set to this state, then it can no
longer be re-armed.
The following script was run to find all the trivial locations where
del_timer() or del_timer_sync() is called in the same function that the
object holding the timer is freed. It also ignores any locations where
the timer->function is modified between the del_timer*() and the free(),
as that is not considered a "trivial" case.
This was created by using a coccinelle script and the following
commands:
$ cat timer.cocci
@@
expression ptr, slab;
identifier timer, rfield;
@@
(
- del_timer(&ptr->timer);
+ timer_shutdown(&ptr->timer);
|
- del_timer_sync(&ptr->timer);
+ timer_shutdown_sync(&ptr->timer);
)
... when strict
when != ptr->timer
(
kfree_rcu(ptr, rfield);
|
kmem_cache_free(slab, ptr);
|
kfree(ptr);
)
$ spatch timer.cocci . > /tmp/t.patch
$ patch -p1 < /tmp/t.patch
Link: https://lore.kernel.org/lkml/20221123201306.823305113@linutronix.de/
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Pavel Machek <pavel@ucw.cz> [ LED ]
Acked-by: Kalle Valo <kvalo@kernel.org> [ wireless ]
Acked-by: Paolo Abeni <pabeni@redhat.com> [ networking ]
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
|
||
|---|---|---|
| .. | ||
| binding.c | ||
| coex.c | ||
| constants.h | ||
| d3.c | ||
| debugfs-vif.c | ||
| debugfs.c | ||
| debugfs.h | ||
| ftm-initiator.c | ||
| ftm-responder.c | ||
| fw-api.h | ||
| fw.c | ||
| led.c | ||
| mac80211.c | ||
| mac-ctxt.c | ||
| Makefile | ||
| mld-key.c | ||
| mvm.h | ||
| nvm.c | ||
| offloading.c | ||
| ops.c | ||
| phy-ctxt.c | ||
| power.c | ||
| quota.c | ||
| rfi.c | ||
| rs-fw.c | ||
| rs.c | ||
| rs.h | ||
| rx.c | ||
| rxmq.c | ||
| scan.c | ||
| sf.c | ||
| sta.c | ||
| sta.h | ||
| tdls.c | ||
| testmode.h | ||
| time-event.c | ||
| time-event.h | ||
| tt.c | ||
| tx.c | ||
| utils.c | ||
| vendor-cmd.c | ||